1874684 - Update Temporal implementation for Duration normalization, part 2

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, task, P3)

Description

[André Bargull [:anba]]

Update Temporal for the changes from https://github.com/tc39/proposal-temporal/pull/2727.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 1: Add Int128 and Uint128 types. r=#spidermonkey-reviewers!

Division operations in Temporal will soon be limited to int128 values. Introduce
Int128 and Uint128 to avoid BigInt allocations for these divisions.

Int128 and Uint128 are both implemented as a pair of uint64_t values. All
basic algorithmic operations are supported. Non-trivial operations were
implemented using the algorithms described in Hacker's Delight, except for
Uint128::toDouble() which was implemented by copying and then adjusting the
code for BigInt::numberValue().

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 2: Limit time portion of durations to <2⁵³ seconds and Use normalized time duration in operations. r=#spidermonkey-reviewers!

Changes from the two commits:

• Normative: Limit time portion of durations to <2⁵³ seconds
• Editorial?: Use normalized time duration in operations

The "Use normalized time duration in operations" commit changes many operations
to use NormalizedTimeDuration instead of Duration. This is a massiv change,
but also allows to remove all BigInt code when extended precision was needed.

Depends on D198534

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 3: Update spec step number references. r=#spidermonkey-reviewers!

Depends on D198535

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 4: Prefer const references instead of copying Instant values. r=#spidermonkey-reviewers!

Consistently use const references instead of sometimes copying Instant values.

Depends on D198536

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 5: Directly convert to DurationObject this-value to Duration value. r=#spidermonkey-reviewers!

This matches other methods and makes the code a bit smaller.

Depends on D198537

Comment 6

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 6: Limit day length calculations to safe integers. r=#spidermonkey-reviewers!

Changes from:

• <commit> here

This also allows to change NormalizedTimeAndDays::{time,dayLength} to use
int64_t values instead of NormalizedTimeDuration.

Depends on D198538

Comment 7

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 7: Limit duration years, months, and weeks to <2³² each. r=#spidermonkey-reviewers!

Changes from:

• <commit>

Depends on D198539

Comment 8

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 8: Prefer integer types for TimeDuration. r=#spidermonkey-reviewers!

The previous changes make it possible to switch most TimeDuration fields to
use int64_t instead of double.

Depends on D198541

Comment 9

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 9: Prefer integer types for DateDuration. r=#spidermonkey-reviewers!

Similar to previous part, prefer int64_t rather than double for DateDuration.

Depends on D198542

Comment 10

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 10: Replace BigInt with Int128 in RoundNumberToIncrement. r=#spidermonkey-reviewers!

Use Int128 instead of BigInt in RoundNumberToIncrement to avoid duplicated
code for the BigInt code path.

Depends on D198543

Comment 11

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 11: Remove no longer needed BigInt code path in TemporalDurationToString. r=#spidermonkey-reviewers!

The value restrictions from the previous parts allow to remove the BigInt code
paths from TemporalDurationToString.

Depends on D198544

Comment 12

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 12: Add separate structs for fractional duration units. r=#spidermonkey-reviewers!

This reduces the differences between the spec and the implementation, so
we have fewer steps which are annotated with "Not applicable in our implementation".

Depends on D198545

Comment 13

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 13: Pass DateDuration to AddDate/CalendarDateAdd. r=#spidermonkey-reviewers!

Prefer DateDuration to avoid unnecessary DateDuration -> Duration -> DateDuration conversions.

Depends on D198546

Comment 14

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 14: Return DateDuration from DifferenceDate. r=#spidermonkey-reviewers!

Similar to the previous part, prefer DateDuration to avoid unnecessary
int64_t -> double -> int64_t conversions.

Depends on D198547

Comment 15

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 15: Prefer int64_t in Add24HourDaysToNormalizedTimeDuration. r=#spidermonkey-reviewers!

Switch to int64_t to avoid some unnecessary int64_t -> double -> int64_t conversions.

Depends on D198548

Comment 16

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 16: Fix "const auto" warnings from clang-tidy. r=#spidermonkey-reviewers!

Depends on D198549

Comment 17

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 17: Fix uninitialised variable warnings from clang-tidy. r=#spidermonkey-reviewers!

Depends on D198550

Comment 18

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 18: Fix narrowing warnings from clang-tidy. r=#spidermonkey-reviewers!

Depends on D198551

Comment 19

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 19: Fix simplify bool-return warnings from clang-tidy. r=#spidermonkey-reviewers!

Depends on D198552

Comment 20

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 20: Tag stack classes with MOZ_STACK_CLASS. r=#spidermonkey-reviewers!

Depends on D198553

Comment 21

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 21: Rename SecondsAndNanoseconds::toTotalNanoseconds. r=#spidermonkey-reviewers!

Depends on D198554

Comment 22

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 22: Compute the precise fraction in Duration.p.total and ZonedDateTime.p.hoursInDay. r=#spidermonkey-reviewers!

Required to pass the tests from https://github.com/tc39/test262/pull/3978.

Depends on D198555

Comment 23

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 23: Editorial updates. r=#spidermonkey-reviewers!

Changes from:

• https://github.com/tc39/proposal-temporal/commit/3a7b3272420a239eda204e30b510bc69f9febbde
• https://github.com/tc39/proposal-temporal/commit/0cd94ebdd6700e4a5d407ae62a6d510b609fabe4
• https://github.com/tc39/proposal-temporal/commit/02e28d43d01263ad570951089889e1ef95a49baf
• https://github.com/tc39/proposal-temporal/commit/3c6072652aec57fa3523c34120f569a91ee2b8fb
• https://github.com/tc39/proposal-temporal/commit/a59d180bb9ce6292a0f02372f75143c7f961a7dc
• https://github.com/tc39/proposal-temporal/commit/1e6f2bb470cc352d1b03da936c197554fec443b2
• https://github.com/tc39/proposal-temporal/commit/42eca97e3a223fc317794fecf7d05c2c4902bf5b
• https://github.com/tc39/proposal-temporal/commit/c4b17d87f54a985dadd4bf0baf3d7b8956c09d2d
• https://github.com/tc39/proposal-temporal/commit/4d612417e7bf70b767a8138eea3fd56bd5d55927
• https://github.com/tc39/proposal-temporal/commit/5b1c732f37a9673594567b194d8d311a2bf3cdbf
• https://github.com/tc39/proposal-temporal/commit/ae85b3c695b7a93c39e9704ce751d36a5c01a1ca
• https://github.com/tc39/proposal-temporal/commit/de5b7ea045a3980eeadd280b33ad520383fb5578
• https://github.com/tc39/proposal-temporal/commit/652ecdd7d059cdd09c1e16e674af19a45fd83e54
• https://github.com/tc39/proposal-temporal/commit/85bf0275ad4f1a8d7f8554a038527161e481a062
• https://github.com/tc39/proposal-temporal/commit/2bdf565cf2b66ef1aabcb6184a8c9e37cd90e425

Depends on D198556

Comment 24

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 24: Prevent arbitrary loops in NormalizedTimeDurationToDays. r=#spidermonkey-reviewers!

Changes from:
https://github.com/tc39/proposal-temporal/commit/5e723bb6899a9378bff99ddccc9e06110e1774cf

Depends on D204387

Comment 25

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 25: Editorial updates. r=#spidermonkey-reviewers!

Changes from:

• https://github.com/tc39/proposal-temporal/commit/b3e2fba5f749d623177c2451e933d16c8b44f357
• https://github.com/tc39/proposal-temporal/commit/307aeee38dcb554913b93a9c35b4b4f4ecfc9f23
• https://github.com/tc39/proposal-temporal/commit/c5ad0c88be7178a9e41ef14b0009a8109117b9e7
• https://github.com/tc39/proposal-temporal/commit/61b6df0c90d0f20985d0e849cf6fa3eaf6301b42
• https://github.com/tc39/proposal-temporal/commit/11a383a9ff64d9778a84bd943b6e8615613fe972
• https://github.com/tc39/proposal-temporal/commit/452b5ac451ccad6234a1a9ddc1cf4a814062cd1b
• https://github.com/tc39/proposal-temporal/commit/a3ef6ce08e9e9607a76506fed43c85fe6b828999
• https://github.com/tc39/proposal-temporal/commit/6d152d19fcf69ca04e91adc81a42d25f5555ede4

Depends on D204388

Comment 26

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 26: Use correct grammar separating punctuation. r=#spidermonkey-reviewers!

Changes from:

• https://github.com/tc39/proposal-temporal/commit/ded1fca31c94dc2665e003a81702e370ff3841fd

Depends on D204389

Comment 27

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 27: Fix unused variables warning. r=#spidermonkey-reviewers!

epochDays is only used in debug-assertions.

Depends on D204390

Comment 28

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 28: Return DateDuration from DifferenceISODateTime. r=#spidermonkey-reviewers!

Callers of DifferenceISODateTime only need the date-duration part.

Depends on D204391

Comment 29

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 29: Update spec fixme notes. r=#spidermonkey-reviewers!

Add/Remove fix-me notes about spec issues.

Depends on D204392

Comment 30

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 30: Make BalanceTimeDuration a fallible operation. r=#spidermonkey-reviewers!

BalanceTimeDuration is fallible, cf. https://github.com/tc39/proposal-temporal/issues/2785.

Depends on D204393

Comment 31

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 31: Correctly reject invalid durations in some RoundDuration calls. r=#spidermonkey-reviewers!

Some RoundDuration calls were incorrectly treated as infallible.

Depends on D204394

Comment 32

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 32: Lazily add 'largestUnit' for CalendarDateUntil. r=#spidermonkey-reviewers!

Move the DefineDataProperty call into the CalendarDateUntilSlow slow-path.

Depends on D204395

Comment 33

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 33: Defer allocation of options object for CalendarDateFromFields. r=#spidermonkey-reviewers!

Move the options object allocation into CalendarDateFromFields. Also filed a
spec issue about removing the options object allocation from the spec.

Depends on D204396

Comment 34

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 34: Lazily allocate PlainDateObject in DifferenceISODateTime. r=#spidermonkey-reviewers!

Move the PlainDateObject allocation into the CalendarDateUntilSlow slow path.

Depends on D204397

Comment 35

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 35: Return DateDuration from CalendarDateUntil. r=#spidermonkey-reviewers!

CalendarDateUntil only care about the date-duration parts.

Depends on D204398

Comment 36

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 36: Add AddDate overload with DateDuration. r=#spidermonkey-reviewers!

Add a AddDate overload which can be called with a DateDuration.

Depends on D204399

Comment 37

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 37: Fix unified compilation. r=#spidermonkey-reviewers!

Fix unified compilation when FILES_PER_UNIFIED_FILE is set to a larger value.

Depends on D204400

Comment 38

[André Bargull [:anba]]

Attachment: Bug 1874684 - Part 38: Enable now passing tests. r=#spidermonkey-reviewers!

Drive-by fix:

• Move exclusions into the correct section.

Depends on D204401

Comment 39

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b02a78c0db03
Part 1: Add Int128 and Uint128 types. r=dminor
https://hg.mozilla.org/integration/autoland/rev/bb9cad9d5457
Part 2: Limit time portion of durations to <2⁵³ seconds and Use normalized time duration in operations. r=dminor
https://hg.mozilla.org/integration/autoland/rev/adece94b6cd5
Part 3: Update spec step number references. r=dminor
https://hg.mozilla.org/integration/autoland/rev/2434d6217427
Part 4: Prefer const references instead of copying Instant values. r=dminor
https://hg.mozilla.org/integration/autoland/rev/6c39d283c5ba
Part 5: Directly convert to DurationObject this-value to Duration value. r=dminor
https://hg.mozilla.org/integration/autoland/rev/50c1e95cd589
Part 6: Limit day length calculations to safe integers. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/c85519789ab4
Part 7: Limit duration years, months, and weeks to <2³² each. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/1e18f460744f
Part 8: Prefer integer types for TimeDuration. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/55bd9a447858
Part 9: Prefer integer types for DateDuration. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/87bc0f5d7800
Part 10: Replace BigInt with Int128 in RoundNumberToIncrement. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/76c0db2530fc
Part 11: Remove no longer needed BigInt code path in TemporalDurationToString. r=sfink
https://hg.mozilla.org/integration/autoland/rev/ee087036bfde
Part 12: Add separate structs for fractional duration units. r=sfink
https://hg.mozilla.org/integration/autoland/rev/b0d05a8b8e22
Part 13: Pass DateDuration to AddDate/CalendarDateAdd. r=sfink
https://hg.mozilla.org/integration/autoland/rev/5afebcb036e1
Part 14: Return DateDuration from DifferenceDate. r=sfink
https://hg.mozilla.org/integration/autoland/rev/9b6b98d5fead
Part 15: Prefer int64_t in Add24HourDaysToNormalizedTimeDuration. r=sfink
https://hg.mozilla.org/integration/autoland/rev/a0a290e457e9
Part 16: Fix "const auto" warnings from clang-tidy. r=allstarschh
https://hg.mozilla.org/integration/autoland/rev/e820dca92042
Part 17: Fix uninitialised variable warnings from clang-tidy. r=allstarschh
https://hg.mozilla.org/integration/autoland/rev/61e7759827c2
Part 18: Fix narrowing warnings from clang-tidy. r=allstarschh
https://hg.mozilla.org/integration/autoland/rev/56187d5fb5f9
Part 19: Fix simplify bool-return warnings from clang-tidy. r=allstarschh
https://hg.mozilla.org/integration/autoland/rev/a07feca4e7ae
Part 20: Tag stack classes with MOZ_STACK_CLASS. r=allstarschh
https://hg.mozilla.org/integration/autoland/rev/692afcdee786
Part 21: Rename SecondsAndNanoseconds::toTotalNanoseconds. r=dminor
https://hg.mozilla.org/integration/autoland/rev/8f7571c34491
Part 22: Compute the precise fraction in Duration.p.total and ZonedDateTime.p.hoursInDay. r=dminor
https://hg.mozilla.org/integration/autoland/rev/c74cb3d432e4
Part 23: Editorial updates. r=dminor
https://hg.mozilla.org/integration/autoland/rev/2b81b1c6fe87
Part 24: Prevent arbitrary loops in NormalizedTimeDurationToDays. r=dminor
https://hg.mozilla.org/integration/autoland/rev/3b5ac166e3a7
Part 25: Editorial updates. r=dminor
https://hg.mozilla.org/integration/autoland/rev/6e19977bc705
Part 26: Use correct grammar separating punctuation. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/0f8568982d17
Part 27: Fix unused variables warning. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/d6e5a4455a39
Part 28: Return DateDuration from DifferenceISODateTime. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/4b588f331ab3
Part 29: Update spec fixme notes. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/3e5f57928b39
Part 30: Make BalanceTimeDuration a fallible operation. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/cb3bd9361fa4
Part 31: Correctly reject invalid durations in some RoundDuration calls. r=sfink
https://hg.mozilla.org/integration/autoland/rev/6ec0be1f4d48
Part 32: Lazily add 'largestUnit' for CalendarDateUntil. r=sfink
https://hg.mozilla.org/integration/autoland/rev/3298e3f5d4a3
Part 33: Defer allocation of options object for CalendarDateFromFields. r=sfink
https://hg.mozilla.org/integration/autoland/rev/387995a61693
Part 34: Lazily allocate PlainDateObject in DifferenceISODateTime. r=sfink
https://hg.mozilla.org/integration/autoland/rev/572a85726123
Part 35: Return DateDuration from CalendarDateUntil. r=sfink
https://hg.mozilla.org/integration/autoland/rev/f4db6404bf94
Part 36: Add AddDate overload with DateDuration. r=allstarschh
https://hg.mozilla.org/integration/autoland/rev/09c240f8a039
Part 37: Fix unified compilation. r=allstarschh
https://hg.mozilla.org/integration/autoland/rev/7918b3068b6c
Part 38: Enable now passing tests. r=allstarschh

Comment 40

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b02a78c0db03
https://hg.mozilla.org/mozilla-central/rev/bb9cad9d5457
https://hg.mozilla.org/mozilla-central/rev/adece94b6cd5
https://hg.mozilla.org/mozilla-central/rev/2434d6217427
https://hg.mozilla.org/mozilla-central/rev/6c39d283c5ba
https://hg.mozilla.org/mozilla-central/rev/50c1e95cd589
https://hg.mozilla.org/mozilla-central/rev/c85519789ab4
https://hg.mozilla.org/mozilla-central/rev/1e18f460744f
https://hg.mozilla.org/mozilla-central/rev/55bd9a447858
https://hg.mozilla.org/mozilla-central/rev/87bc0f5d7800
https://hg.mozilla.org/mozilla-central/rev/76c0db2530fc
https://hg.mozilla.org/mozilla-central/rev/ee087036bfde
https://hg.mozilla.org/mozilla-central/rev/b0d05a8b8e22
https://hg.mozilla.org/mozilla-central/rev/5afebcb036e1
https://hg.mozilla.org/mozilla-central/rev/9b6b98d5fead
https://hg.mozilla.org/mozilla-central/rev/a0a290e457e9
https://hg.mozilla.org/mozilla-central/rev/e820dca92042
https://hg.mozilla.org/mozilla-central/rev/61e7759827c2
https://hg.mozilla.org/mozilla-central/rev/56187d5fb5f9
https://hg.mozilla.org/mozilla-central/rev/a07feca4e7ae
https://hg.mozilla.org/mozilla-central/rev/692afcdee786
https://hg.mozilla.org/mozilla-central/rev/8f7571c34491
https://hg.mozilla.org/mozilla-central/rev/c74cb3d432e4
https://hg.mozilla.org/mozilla-central/rev/2b81b1c6fe87
https://hg.mozilla.org/mozilla-central/rev/3b5ac166e3a7
https://hg.mozilla.org/mozilla-central/rev/6e19977bc705
https://hg.mozilla.org/mozilla-central/rev/0f8568982d17
https://hg.mozilla.org/mozilla-central/rev/d6e5a4455a39
https://hg.mozilla.org/mozilla-central/rev/4b588f331ab3
https://hg.mozilla.org/mozilla-central/rev/3e5f57928b39
https://hg.mozilla.org/mozilla-central/rev/cb3bd9361fa4
https://hg.mozilla.org/mozilla-central/rev/6ec0be1f4d48
https://hg.mozilla.org/mozilla-central/rev/3298e3f5d4a3
https://hg.mozilla.org/mozilla-central/rev/387995a61693
https://hg.mozilla.org/mozilla-central/rev/572a85726123
https://hg.mozilla.org/mozilla-central/rev/f4db6404bf94
https://hg.mozilla.org/mozilla-central/rev/09c240f8a039
https://hg.mozilla.org/mozilla-central/rev/7918b3068b6c