1874705 - CSS pseudo class :has in combination with HTMLTemplateElement

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Pascal[:pascalav]]

Steps to reproduce:

You can simulate the bug(?) with JSFiddle click by click.

Both examples show the error in the Firefox browser under Kubuntu (Snap version 121.0.1-1). Once with document.createElement('template') and once with the template tag in the body. The result is the same.

https://jsfiddle.net/o5fuztr0/1/
or
https://jsfiddle.net/o5fuztr0/

User-Agent: "Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:121.0) Gecko/20100101 Firefox/121.0"

Actual results:

If you use the CSS pseudo class :has in combination with templates, the CSS property is not updated when the template is inserted into the DOM.

Expected results:

The stored CSS properties should be displayed. In the example here the background color. However, this applies to all properties. Also display: none etc.

Comment 1

[David Shin[:dshin]]

Attachment: Minimum Reproducible Case

Thanks for filing!

Minimum reproducible case for the root cause attached.
Root cause is here where in a multiple append scenario, we skip invalidation if the first node is not an element.

Comment 2

[David Shin[:dshin]]

Attachment: Bug 1874705: Run invalidation on appended elements even if the first node is not an element. r=#style

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46d015f0153a
Run invalidation on appended elements even if the first node is not an element. r=firefox-style-system-reviewers,emilio

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44019 for changes under testing/web-platform/tests

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/46d015f0153a

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 8

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-01-15 Nightly build on macOS 12.
Verified as fixed on Firefox 123.0 and Firefox Nightly 124.0a1 on Windows 10, Ubuntu 22, macOS 12.