1874810 - Implement RecordedStrokeGlyphs

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, enhancement)

Comment 1

[Lee Salzman [:lsalzman]]

Attachment: Bug 1874810 - Implement RecordedStrokeGlyphs. r?aosmond

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28c56a4f3af6
Implement RecordedStrokeGlyphs. r=aosmond

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out for causing Moz2DImageRenderer related failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=P4xr_q-kQvCQpTIPZVPJNw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=28c56a4f3af6c7f53da1ada840b1c04821afffa7

Failure log: https://treeherder.mozilla.org/logviewer?job_id=443552315&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/2a7dd75d1bfc1693115b94b3e424e58b331cefab

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71000174812f
Implement RecordedStrokeGlyphs. r=aosmond

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/71000174812f

Comment 6

[Emilio Cobos Álvarez (:emilio)]

The fuzz in https://phabricator.services.mozilla.com/differential/changeset/?ref=7260357 seems rather unfortunate, makes the tests basically useless... Can we do a bit better? Why are there so many (and so much) different pixels?

Comment 7

[Lee Salzman [:lsalzman]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #6)

The fuzz in https://phabricator.services.mozilla.com/differential/changeset/?ref=7260357 seems rather unfortunate, makes the tests basically useless... Can we do a bit better? Why are there so many (and so much) different pixels?

The tests seem on some level broken since they are comparing svg rendering vs html rendering, passing different stroking options (line join round vs. miter), one uses DrawTargetRecording vs one doesn't. It would be better if they took a similar rendering path, otherwise, any similarity is luck, rather than intentional.