Add labeled_counter to collect the heuristic that detected a form submission
Categories
(Toolkit :: Form Autofill, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox124 | --- | fixed |
People
(Reporter: janikaneuberger, Assigned: janikaneuberger)
References
Details
(Whiteboard: [fxcm-addr-compatibility])
Attachments
(2 files)
2.54 KB,
text/plain
|
chutten
:
data-review+
|
Details |
48 bytes,
text/x-phabricator-request
|
Details | Review |
Assignee | ||
Comment 1•4 months ago
|
||
Assignee | ||
Comment 2•4 months ago
|
||
Updated answer to question 7 of the data review request:
How long will this data be collected?
New answer: This collection has expiry 130.
Assignee | ||
Updated•4 months ago
|
Assignee | ||
Comment 3•4 months ago
|
||
Comment 4•4 months ago
|
||
Comment on attachment 9372999 [details]
request_form_submission_heuristic.md
PRELIMINARY NOTES:
The review request says This collection has expiry '6'.
when it actually expires in 130.
Was this the result of running it on an earlier version of the metrics.yaml?
DATA COLLECTION REVIEW RESPONSE:
Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?
Yes.
Is there a control mechanism that allows the user to turn the data collection on and off?
Yes. This collection can be controlled through Firefox's Preferences.
If the request is for permanent data collection, is there someone who will monitor the data over time?
No. This collection will expire in Firefox 130.
Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Category 1, Technical.
Is the data collection request for default-on or default-off?
Default on for all channels.
Does the instrumentation include the addition of any new identifiers?
No.
Is the data collection covered by the existing Firefox privacy notice?
Yes.
Does the data collection use a third-party collection tool?
No.
Result: datareview+
Assignee | ||
Comment 5•4 months ago
|
||
Thanks for the review @chutten!
Yes, I ran the glean_parser
on an earlier version which had "6" assigned to the "expires" property. I thought that was a valid assignment, but as it turned out, it wasn't. I updated it in comment 2.
Pushed by jneuberger@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5c38b3e5008b Add labeled_counter to collect the heuristic that detects a form submission r=credential-management-reviewers,dimi
Comment 7•4 months ago
|
||
bugherder |
Description
•