1874917 - Rename SearchTestUtils.promiseNewSearchEngine to installOpenSearchEngine or something similar

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

We want to improve the naming SearchTestUtils.promiseNewSearchEngine to be more descriptive that it is installing an OpenSearch based engine. Something like SearchTestUtils.installOpenSearchEngine.

Comment 1

[Mark Banner (:standard8)]

This can be a mentored bug, should be fairly trivial as a good-first-bug.

Here's a useful link for what needs renaming:

https://searchfox.org/mozilla-central/search?q=SearchTestUtils.promiseNewSearchEngine&path=&case=false&regexp=false

We do want to go with SearchTestUtils.installOpenSearchEngine for the new name.

If you need to know how to get started with repository set-up, committing or submitting patches, please see this link.

Comment 2

[Ujas Thakkar]

Hi Mark, would like to take this mentored bug on.

I am just starting out on open source and found this bug a good opportunity.

Comment 3

[Sukhmeet[:sukh]]

(In reply to Ujas Thakkar from comment #2)

Hi Mark, would like to take this mentored bug on.

I am just starting out on open source and found this bug a good opportunity.

Hi Ujas,

I am a fellow contributor. Follow the setup link and then send the patch with the required renaming.

Comment 4

[Ujas Thakkar]

Attachment: Bug 1874917 - Rename SearchTestUtils.promiseNewSearchEngine to SearchTestUtils.installOpenSearchEngine r=Standard8

Comment 5

[Ujas Thakkar]

Hi Mark,

I have just submitted the patch for review.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f529d0a453c7
Rename SearchTestUtils.promiseNewSearchEngine to SearchTestUtils.installOpenSearchEngine r=Standard8

Comment 7

[Ujas Thakkar]

Hi Mark,

Thank you for taking out time for the review. It was a great experience making my first ever contribution.

Now that this issue is over, do you think there are some additional issues that I could work on for fixing?

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f529d0a453c7