Closed Bug 1874917 Opened 5 months ago Closed 21 days ago

Rename SearchTestUtils.promiseNewSearchEngine to installOpenSearchEngine or something similar

Categories

(Firefox :: Search, task, P3)

task

Tracking

()

RESOLVED FIXED
128 Branch
Tracking Status
firefox128 --- fixed

People

(Reporter: standard8, Assigned: thakkarujas5, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(1 file)

We want to improve the naming SearchTestUtils.promiseNewSearchEngine to be more descriptive that it is installing an OpenSearch based engine. Something like SearchTestUtils.installOpenSearchEngine.

This can be a mentored bug, should be fairly trivial as a good-first-bug.

Here's a useful link for what needs renaming:

https://searchfox.org/mozilla-central/search?q=SearchTestUtils.promiseNewSearchEngine&path=&case=false&regexp=false

We do want to go with SearchTestUtils.installOpenSearchEngine for the new name.

If you need to know how to get started with repository set-up, committing or submitting patches, please see this link.

Mentor: standard8
Keywords: good-first-bug
Whiteboard: [lang=js]

Hi Mark, would like to take this mentored bug on.

I am just starting out on open source and found this bug a good opportunity.

(In reply to Ujas Thakkar from comment #2)

Hi Mark, would like to take this mentored bug on.

I am just starting out on open source and found this bug a good opportunity.

Hi Ujas,

I am a fellow contributor. Follow the setup link and then send the patch with the required renaming.

Assignee: nobody → thakkarujas5
Status: NEW → ASSIGNED

Hi Mark,

I have just submitted the patch for review.

Attachment #9403415 - Attachment description: Bug 1874917 - Renamed SearchTestUtils.promiseNewSearchEngine to SearchTestUtils.installOpenSearchEngine r=Standard8 → Bug 1874917 - Rename SearchTestUtils.promiseNewSearchEngine to SearchTestUtils.installOpenSearchEngine r=Standard8
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f529d0a453c7
Rename SearchTestUtils.promiseNewSearchEngine to SearchTestUtils.installOpenSearchEngine r=Standard8

Hi Mark,

Thank you for taking out time for the review. It was a great experience making my first ever contribution.

Now that this issue is over, do you think there are some additional issues that I could work on for fixing?

Status: ASSIGNED → RESOLVED
Closed: 21 days ago
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: