Rename SearchTestUtils.promiseNewSearchEngine to installOpenSearchEngine or something similar
Categories
(Firefox :: Search, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox128 | --- | fixed |
People
(Reporter: standard8, Assigned: thakkarujas5, Mentored)
Details
(Keywords: good-first-bug, Whiteboard: [lang=js])
Attachments
(1 file)
We want to improve the naming SearchTestUtils.promiseNewSearchEngine to be more descriptive that it is installing an OpenSearch based engine. Something like SearchTestUtils.installOpenSearchEngine.
|
Reporter | |
Comment 1•2 months ago
|
||
This can be a mentored bug, should be fairly trivial as a good-first-bug.
Here's a useful link for what needs renaming:
We do want to go with SearchTestUtils.installOpenSearchEngine for the new name.
If you need to know how to get started with repository set-up, committing or submitting patches, please see this link.
|
Assignee | |
Comment 2•2 months ago
|
||
Hi Mark, would like to take this mentored bug on.
I am just starting out on open source and found this bug a good opportunity.
|
||
Comment 3•2 months ago
|
||
(In reply to Ujas Thakkar from comment #2)
Hi Mark, would like to take this mentored bug on.
I am just starting out on open source and found this bug a good opportunity.
Hi Ujas,
I am a fellow contributor. Follow the setup link and then send the patch with the required renaming.
|
|
Assignee | |
Comment 4•1 month ago
|
||
|
||
Updated•1 month ago
|
|
|
Assignee | |
Comment 5•1 month ago
|
||
Hi Mark,
I have just submitted the patch for review.
|
|
||
Updated•1 month ago
|
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f529d0a453c7 Rename SearchTestUtils.promiseNewSearchEngine to SearchTestUtils.installOpenSearchEngine r=Standard8
|
|
Assignee | |
Comment 7•1 month ago
|
||
Hi Mark,
Thank you for taking out time for the review. It was a great experience making my first ever contribution.
Now that this issue is over, do you think there are some additional issues that I could work on for fixing?
|
||
Comment 8•1 month ago
|
||
| bugherder | ||
Description
•