1874957 - Add a shouldLog function to console instances created by console.createInstance

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Mark Banner (:standard8)]

The current Console.sys.mjs has a shouldLog(level) function that allows code to check if a message should be logged or not.

This allows for situations where code wants to know if to log or not, or if there's a case where we want to avoid unnecessary work for a log message.

Having an equivalent available on ConsoleInstance would allow us to move more code across to it.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1874957 - Add a shouldLog function to ConsoleInstance. r?#dom-core!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc082de0e841
Add a shouldLog function to ConsoleInstance. r=dom-core,webidl,saschanaz,peterv

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser/base/content/test/performance/browser_preferences_usage.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/9671c91b2f911688db923e6e3f152ca68f2028af

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_preferences_usage.js | Should have accessed all known problematic prefs. Remaining: browser.translations.logLevel

Comment 5

[Mark Banner (:standard8)]

Issue is in bug 1876589

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2e01b74440f
Add a shouldLog function to ConsoleInstance. r=dom-core,webidl,saschanaz,peterv

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/d2e01b74440f