1874958 - ServiceWorkerRegistration.showNotification put notification to DB even without notification permission

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, defect, P2)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1873229#c18.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Broken notification with incorrect icon string also goes to the DB without being shown, but that seems to happen only without permission.

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: WIP: Bug 1874958

Depends on D198836

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1874958 - Do not call CreateAndShow with the default permission r=asuth

Somehow we ended up throwing if it's explicitly denied. Now it throws error with the default permission too.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab5b008e36a4
Do not call CreateAndShow with the default permission r=asuth

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44433 for changes under testing/web-platform/tests

Comment 6

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/ab5b008e36a4

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot