Closed Bug 1874958 Opened 5 months ago Closed 4 months ago

ServiceWorkerRegistration.showNotification put notification to DB even without notification permission

Categories

(Core :: DOM: Push Subscriptions, defect, P2)

Product:
Core
Component:
DOM: Push Subscriptions
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
124 Branch
Tracking Flags:
Tracking Status
firefox124 --- fixed

People

(Reporter: saschanaz, Assigned: saschanaz)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1874958 - Do not call CreateAndShow with the default permission r=asuth
48 bytes, text/x-phabricator-request
Details | Review

Broken notification with incorrect icon string also goes to the DB without being shown, but that seems to happen only without permission.

Attached file WIP: Bug 1874958 (obsolete) —

Depends on D198836

Severity: -- → S3
Priority: -- → P2
Attachment #9373328 - Attachment is obsolete: true

Somehow we ended up throwing if it's explicitly denied. Now it throws error with the default permission too.

Attachment #9378557 - Attachment description: WIP: Bug 1874958 - Part 1: Do not call CreateAndShow with the default permission r=asuth → Bug 1874958 - Do not call CreateAndShow with the default permission r=asuth
Pushed by krosylight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ab5b008e36a4
Do not call CreateAndShow with the default permission r=asuth
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44433 for changes under testing/web-platform/tests

https://hg.mozilla.org/mozilla-central/rev/ab5b008e36a4

Status: NEW → RESOLVED
Closed: 4 months ago
status-firefox124: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
Upstream PR merged by moz-wptsync-bot
See Also: → 1891809
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: