Apply touchmode rules to all OSes
Categories
(Firefox :: Menus, enhancement)
Tracking
()
People
(Reporter: saschanaz, Assigned: saschanaz)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
Attachments
(4 files)
Assignee | ||
Comment 1•8 months ago
|
||
Updated•8 months ago
|
Assignee | ||
Comment 2•8 months ago
|
||
Revert "Backed out changeset 3d1ef5fe232a (bug 1874301) as requested by Kagami for causing css overflow issue that blocks accessing app menu on certain devices."
This reverts commit 74b2316865d9b72ddcc62ede4933bf972847017e.
Depends on D198801
Comment 3•8 months ago
|
||
Without this beta simulation jobs will fail with the previous patches.
Assignee | ||
Updated•8 months ago
|
Comment 5•8 months ago
|
||
bugherder |
Updated•8 months ago
|
Comment 7•8 months ago
|
||
Backed out for causing bc failures on browser_menu_touch.js
Updated•8 months ago
|
Assignee | ||
Comment 9•8 months ago
|
||
Those sizes are affected by zoom again, so they need to be decreased.
Assignee | ||
Comment 10•8 months ago
|
||
The third patch is full of hacks and still it has test failures that I can't really understand. https://treeherder.mozilla.org/jobs?repo=try&revision=de77c1989d4106a5a6819a0ca776c6197bf44f98&selectedTaskRun=YqoWjCTfQW6wRS-11pI2Pg.0
Emilio, any idea how to make it less hacky with zoom? Otherwise I think I'd rather go for simply moving the rules rather than adding hacks.
Comment 11•8 months ago
|
||
I'm confused, how does your code in comment 9 and so have anything to do with those failures? The zoom factor should effectively always be 1 there, right? Do the failures reproduce if you just flush style some other way like calling getComputedStyle(this._panel).fontSize
or something?
Assignee | ||
Comment 12•8 months ago
|
||
If I revert comment #9 those failures go away, I'll check with getComputedStyle.
Assignee | ||
Comment 13•8 months ago
|
||
Okay I updated the patch, there was a mistake that was somehow silently causing failures.
It's still hacky but I think it should work for now...
Assignee | ||
Comment 15•5 months ago
|
||
Emilio wanted to have a better way of getting zoom level which is now specced and implemented as currentCSSZoom, but it flushes. Maybe we can add a non-flushing chrome-only attribute, or even zoom-agnostic getBounds function.
Thoughts, Emilio?
Comment 16•5 months ago
|
||
Zoom-agnostic getBounds is getBoundingClientRect or the equivalent non-flushing functions right?
Adding a currentCSSZoomWithoutFlushing or something makes sense to me.
Assignee | ||
Comment 17•5 months ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #16)
Zoom-agnostic getBounds is getBoundingClientRect or the equivalent non-flushing functions right?
Yeah, the reason we need zoom level right now is to reduce the width/height returned by getBounding, so perhaps we can have a helper function instead of exposing non-flush zoom attribute.
Adding a currentCSSZoomWithoutFlushing or something makes sense to me.
But yeah this works for me too.
Description
•