Closed Bug 1875097 Opened 1 year ago Closed 1 year ago

Port the mozwer-rust crate to windows-sys

Categories

(Toolkit :: Crash Reporting, task)

task

Tracking

()

RESOLVED FIXED
124 Branch
Tracking Status
firefox124 --- fixed

People

(Reporter: gsvelto, Assigned: afranchuk)

References

Details

Attachments

(1 file)

mozwer-rust was written using winapi plus a few hand-rolled bindings, time to move it to windows-sys.

Assignee: nobody → afranchuk
Status: NEW → ASSIGNED

This exchanges winapi functions/types for equivalent windows-sys ones. Some basic types (e.g.
PBOOL) don't exist in windows-sys, and I added type items for them (though those could be
removed and the types inlined; that's what windows-sys does itself).

The psapi library needed to be added for GetModuleFileNameExW; I guess previously winapi was
linking it?

Almost all manual definitions of types (winapi::ENUM! and winapi::STRUCT!) were no longer needed
because windows-sys has them. Only the version of RTL_USER_PROCESS_PARAMETERS with undocumented
fields was still needed.

I think we're good to land here, right?

Just a rebase is needed, I'll do it shortly.

Pushed by afranchuk@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5d65a20200b7 Port the mozwer-rust crate to windows-sys r=gsvelto,glandium
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: