1875137 - :has in display:none doesn't behave as expected

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[coals-worker0q]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.2.1 Safari/605.1.15

Steps to reproduce:

Using :has in combination with other selectors seems to have no effect, unless some action is taken to cause the browser to 'redraw'.

I made 3 reproduced examples for the Mozilla team here: https://2a476f4e.spence.pages.dev/debug/

Actual results:

The conditions that should trigger the has selector don't initially take any effect. After, however, if anything is done to cause the page to be "redrawn", such as resizing the window, changing the zoom amount, or opening the dev console, then the CSS rules related to the has selector will be triggered.

Expected results:

The has selector should update the applicable CSS properties when conditions call for it do so.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::CSS Parsing and Computation' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: reduced test-case

Invalidation issue if the relevant element is display: none (if you remove display: none from the div container it works).

I'm going to bet this. David, do you have cycles to look?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1875137 - Don't ignore state changes in display: none subtrees if needed for :has(). r=dshin,#style

Just like we do for attribute invalidation.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Actually just confirmed that's the issue.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68ff26df3346
Don't ignore state changes in display: none subtrees if needed for :has(). r=dshin

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44070 for changes under testing/web-platform/tests

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/68ff26df3346

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot