1875216 - Remove XPCOMUtils.defineLazyGetter

Status: RESOLVED FIXED

(Core :: XPConnect, task)

Description

[Gregory Pappas [:gregp]]

See bug 1820099 for more context

Comment 1

[Gregory Pappas [:gregp]]

Attachment: Bug 1875216 - part 1: Remove XPCOMUtils.defineLazyGetter

Comment 2

[Gregory Pappas [:gregp]]

Attachment: Bug 1875216 - part 2: Remove linting for XPCOMUtils.defineLazyGetter

Depends on D202126

Comment 3

[Tooru Fujisawa [:arai]]

The JSM loader and related methods are removed, and this patch stack can now also be landed.
Thank you for waiting for the migration period.

Comment 4

[Gregory Pappas [:gregp]]

I think if we land this, we will break the new tab in China repack.

https://github.com/mozilla-extensions/china-newtab

I think a new release of china-newtab needs to be published to prevent breakage. There might also be other privileged extensions that need to be updated

Comment 5

[Tooru Fujisawa [:arai]]

Good point!

Just to make sure my understanding, I see the patch to replace the consumer is already merged.
the problem is that no new version had been released since then, right?
https://github.com/mozilla-extensions/china-newtab/commit/a5dcd48167a0bd3264e51d1c0761a8666e1f280d

Comment 6

[Gregory Pappas [:gregp]]

the problem is that no new version had been released since then, right?

Yes, that is the problem.

Comment 7

[Tooru Fujisawa [:arai]]

I've asked in addons-pipeline slack channel, and the conclusion is that we don't have to wait for the extension.

So, if there's no other affected privileged extensions, we should be ready.
Perhaps it's nice to send an announcement email beforehand, given this wasn't sufficiently covered by the ESMification email.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4a6844bc904
part 1: Remove XPCOMUtils.defineLazyGetter r=arai,Standard8,robwu
https://hg.mozilla.org/integration/autoland/rev/514df798e893
part 2: Remove linting for XPCOMUtils.defineLazyGetter r=arai,Standard8,frontend-codestyle-reviewers,mossop

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c4a6844bc904
https://hg.mozilla.org/mozilla-central/rev/514df798e893