1875229 - Add support for extensions not allowed in private windows

Status: RESOLVED FIXED

(Fenix :: WebExtensions, enhancement, P2)

Description

[Tom25519]

Steps to reproduce:

1. Install extension "Essential Buttons Toolbar" https://addons.mozilla.org/zh-CN/android/addon/essential-buttons-toolbar/
2. Check "Allow in private browsing", touch "OK, got it"
3. Enter add-on manager->Essential Buttons Toolbar

Actual results:

"Run in private browsing" is still disabled, if you enable it, it will still keeping after you re-enter.

Expected results:

This bug shouldn't appear.

Comment 1

[jackyzy823]

The add-on choose to not work under private mode.

https://github.com/KristhianX/essential-buttons-toolbar/blob/e6debf98ff2fcd5b6ee75a5712716bfb1e8dcf20/manifest.json#L5C1-L5C32

"incognito": "not_allowed",

Comment 2

[jackyzy823]

So the bug should be

When add-on set "incognito": "not_allowed" in manifest.json

1. don't show the dialog asking user if enable it in private mode when installing
2. in add-ons detail page, don't show switch for "running in the private mode" or make it unclickable.

Ref: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/incognito

Comment 3

[Tom25519]

I think it would better to notice user that this extension couldn't run in private mode due to itself limitation.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:zmckenney, could you have a look please?

For more information, please visit BugBot documentation.

Comment 5

[William Durand [:willdurand]]

I agree, I am going to re-purpose this bug a tiny bit.

Comment 6

[William Durand [:willdurand]]

Attachment: Bug 1875229 - Expose `incognito` add-on property to the embedder. r?amejiamarmol!

Comment 7

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1875229 - Add support for extensions not allowed in private windows (#5571)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5d935fdedd6
Expose `incognito` add-on property to the embedder. r=amejiamarmol,geckoview-reviewers,zmckenney

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a5d935fdedd6

Comment 10

[BMO Github Automation]

Authored by https://github.com/willdurand
https://github.com/mozilla-mobile/firefox-android/commit/fb472ef6e96db30b7d1843d18b223509ad05c209
[main] Bug 1875229 - Add support for extensions not allowed in private windows

Comment 11

[William Durand [:willdurand]]

For QA, please also verify with all kind of combinations of enabled/disabled states (with re-entering the detail view by first going back to the list and the to the add-on again). For an add-on like the one mentioned in Comment 0, we should never see "Run in private ..." in the detail view.

Comment 12

[Adina Petridean QA [:apetridean]]

Verified as fixed on the latest Nightly with 124.0a1 from 15.02.2024 with Motorola G9 plus (Android 11) and OnePlus A3000 (Android 6).

Comment 13

[Adina Petridean QA [:apetridean]]

Attachment: Add-on.mp4

Comment 14

[Dianna Smith [:diannaS]]

:willdurand is there anything here you would like to mention in the 124 release notes?

Comment 15

[William Durand [:willdurand]]

No, I don't think we need relnotes here.