1875259 - The tabs' tray more options sticks when turning from portrait to landscape and viceversa

Status: NEW

(Fenix :: Tabs, defect)

Description

[miralobontiu]

Steps to reproduce

1. Open a couple of tabs, and open the tabs tray.
2. Tap on the three-dot menu from the tabs tray, then turn the device in landscape mode.
3. Observe the menu, while changing the device's orientation.

Expected behavior

The menu is dismissed every time the user changes the device's orientation (according to https://github.com/mozilla-mobile/fenix/pull/12591).

Actual behavior

The menu sticks when the user changes the orientation.

Device information

• Firefox versions: all (RC 121.1.0, RC 122.0, Beta 122.0b9, Nightly 123.0a1)
• Android devices: Samsung Galaxy S23 Ultra (Android 14), Google Pixel 6 (Android 14), Samsung Galaxy A14 (Android 13), Oppo Find X3 Lite (Andorid 11)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Fenix::Tabs' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[miralobontiu]

Attachment: logcat.txt

Comment 3

[Alexandra Virvara]

I did some investigation on this ticket and it seems that the enabledTrayToCompose flag from Secret Settings is set to true, due some previous testing. After setting this flag to false, the issue seemed to have disappeared. It might be an issue though when we want to test tabs tray with compose

Comment 4

[miralobontiu]

Attachment: screen-20240205-132727_Trim.mp4

I've retested with the "Enabled tabs Tray to Compose rewrite" toggle disabled, and the issue still reproduces.
Tested on today's Fenix nightly 124.0a1 with a Google Pixel 6 (Android 14).

Comment 5

[Noah Bond [:007]]

Hey Mira, similar to that other ticket I tagged you in, whenever you have a chance, could you please verify if this is still an issue? I'll link it to an appropriate meta if it is.

Comment 6

[miralobontiu]

Hi, Noah!

I've verified on the latest Fenix Nightly 126.0a1 from 4/5, and this issue is now fixed on this version.

However, it is still reproducible on Beta 125.0b8, and RC 124.2.0 on Oppo Find N2 Flip (Android 14).
And reproducible on RC 124.2.0 on Google Pixel 6 (Android 14), Samsung Galaxy Tab S8 Ultra (Android 12) (on these devices, it is not reproducible on the latest Beta).

I'll mark this ticket accordingly.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

What release is the Compose rewrite targeting to ship in?

Comment 8

[Noah Bond [:007]]

We're hoping to flip the flag (to enable it by default in all flavors) in 127 and let it ride the trains

Comment 9

[Ryan VanderMeulen [:RyanVM]]

OK. IMO we shouldn't be setting this to verified until the fix is ready to ride the trains as users receiving Fx126 won't actually be seeing the fix.