1875468 - 17.06 - 4.16% damp custom.styleeditor.close.DAMP / damp custom.styleeditor.open.DAMP + 9 more (Linux, Windows) regression on Mon January 15 2024

Status: NEW

(DevTools :: Debugger, defect, P3)

Description

[Hubert Boma Manilla (:bomsy)]

Perfherder has detected a devtools performance regression from push 253b1ef032b4e35683449c7af5d9effaa417e813. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
17%	damp custom.styleeditor.close.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender-sw	9.98 -> 11.68
16%	damp custom.styleeditor.close.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender	10.13 -> 11.78
11%	damp custom.styleeditor.close.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	9.87 -> 10.92
10%	damp custom.styleeditor.close.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	10.50 -> 11.58
7%	damp custom.styleeditor.open.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	704.30 -> 752.73
7%	damp custom.styleeditor.open.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	718.71 -> 765.65
6%	damp browser-toolbox.styleeditor-ready.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender	441.47 -> 468.11
6%	damp browser-toolbox.styleeditor-ready.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender-sw	442.58 -> 468.80
6%	damp complicated.styleeditor.open.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	411.42 -> 435.09
4%	damp custom.styleeditor.open.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender-sw	622.49 -> 649.32
4%	damp custom.styleeditor.open.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender	625.68 -> 651.71

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
5%	damp complicated.styleeditor.open.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender-sw	356.48 -> 339.11
4%	damp complicated.styleeditor.open.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender	357.56 -> 343.55

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 41040

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1834725

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1834725

Comment 3

[Bob Hood [:bhood]]

:bomsy, could you please assign Priority/Severity ratings to this report when you get a chance?

Comment 4

[Alexandre Poirot [:ochameau]]

Manual push to DAMP confirms the regression:
https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=f1221ff46a0efc0b6d970aeca0fb0a3a85ab6267&originalSignature=4763542&newSignature=4763542&framework=12&application=firefox&originalRevision=ab35bf09a76da9702aa8aacab587cf148063d7fc&page=1&showOnlyConfident=1
The important one if 7% on custom.styleeditor.open.

Unfortunately, nothing really stands out when looking at profiles:
https://share.firefox.dev/3K9mqLG