1875524 - Add a "WindowManager.supportsWindows()" helper to more easily check for multiple windows support

Status: RESOLVED FIXED

(Remote Protocol :: Agent, enhancement, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Filed based on the discussion in the following Phabricator revision:
https://phabricator.services.mozilla.com/D199066#inline-1104049

To ease the checks for Marionette and WebDriver BiDi if on a given platform new windows are supported we should have a supportsWindows() method in the WindowManager module, which would be similar to TabManager.supportsTabs().

With that helper command added we could simplify the checks in Marionette (WebDriver:NewWindow command) and WebDriver BiDi (browsingContext.create command) to have something like:

let type;
if (typeHint == "tab" && supportsTabs() || typeHint == "window" && supportsWindows()) {
  type = typeHint;
} else if (lazy.TabManager.supportsTabs()) {
  type = "tab";
} else if (lazy.WindowManager.supportsWindows()) {
  type = "window";
} else {
  // throw appropriate error
}

Comment 1

[Spencer]

Hi, it's been some time, but may I take on this bug if it's still available?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Yes, it's available given that no-one else commented on the bug recently and no patch is attached. So feel free to pick it up. Thanks!

Comment 3

[Spencer]

Attachment: Bug 1875524 - [remote] Add a "WindowManager.supportsWindows()" helper to check for multiple window support

• Added supportsWindows method to WindowManager.
• Refactored type selection in browsingContext.create to use an if/else block
  that uses supportsTabs and supportsWindows to determine the type.
• Removed the supportsTabs check from the "tab" case as the same check is now
  performed in the type selection if/else block.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Hi Spencer, I wanted to check back with you if you would have the time currently to update the reviewed patch. If it takes longer then no worries. Thanks.

Comment 5

[Spencer]

Hi Henrik,

Apologies for the delay, life got busy and had to take a step back for a while. Starting from around this time next week I'll be able to sit back down and work on it. If that's no trouble despite the time, then I will take a look at it then.

Thanks,
-Spencer

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a842a70b6fc0
https://hg.mozilla.org/integration/autoland/rev/c0044be83c85
[remote] Add a "WindowManager.supportsWindows()" helper to check for multiple window support r=whimboo,webdriver-reviewers

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c0044be83c85

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thank you Spencer for getting this feature added! Please let us know if you have interest to work on some other bug - or just find one yourself.