1875642 - Font used for subtext in new Clear Data Dialog is too small

Status: RESOLVED FIXED

(Toolkit :: Data Sanitization, defect, P2)

Description

[Francesco Lodolo [:flod]]

Attachment: Screenshot of Italian Build

The font is barely readable in Italian (font size shows up as 9.537px). I expect languages like Chinese, Japanese, or Arabic to have issues at this font dimension.

For context, see also this issue for the tab media notification
https://bugzilla.mozilla.org/show_bug.cgi?id=1699841#c3

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Screenshot zh-TW build

Note: the English text is expected, since some strings are still waiting in quarantine.

Comment 2

[Francesco Lodolo [:flod]]

Feedback from one of our zh-CN translators: on a low-resolution screen the text is basically unrecognizable, on higher resolution it's better but still too small to read easily.

Comment 3

[Dan Mehic]

Thanks for reporting this. We'll run it by UX team.

Comment 4

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1875642 - Updated font size for description to be bigger in the new clear history dialog. r?pbz

Depends on D199581

Comment 5

[Mark Striemer [:mstriemer]]

Attachment: with-moz-button-changes.png

How soon is this supposed to be enabled? This is an issue I ran into as well when updating some buttons (bug 1835869) in similar dialogs and the changes there seem to fix this too

Comment 6

[Dão Gottwald [:dao]]

(In reply to Francesco Lodolo [:flod] from comment #0)

Created attachment 9375623 [details]
Screenshot of Italian Build

The font is barely readable in Italian (font size shows up as 9.537px).

I assume this is on Mac?

Comment 7

[Francesco Lodolo [:flod]]

My report is for macOS, but I don't have access to other platforms to confirm if it happens there too.

Comment 8

[Harshit Sohaney [:hsohaney]]

(In reply to Mark Striemer [:mstriemer] from comment #5)

Created attachment 9376383 [details]
with-moz-button-changes.png

How soon is this supposed to be enabled? This is an issue I ran into as well when updating some buttons (bug 1835869) in similar dialogs and the changes there seem to fix this too

We were looking to enable the dialog in nightly within the next week.

We've brought it up with UX to see what needs to be done in this case. It could be a bigger problem with the "text-demphasized" class since that is what I used for the description (https://searchfox.org/mozilla-central/source/browser/base/content/sanitize_v2.xhtml#161)

Comment 9

[Mark Striemer [:mstriemer]]

The issue isn't with the text-deemphasized class per se but it's with the base formatting of these dialogs. This wouldn't be the only dialog that is affected.

Basically the dialogs are pretending to be in-content where we use 15px font size and we want text-deemphasized to be smaller, but these dialogs actually override the text to be 11px, which is causing the text-deemphasized class to make the font way too small.

There isn't anything wrong with the text-deemphasized class, just the CSS that is setting up our base font sizes that it is using, that's what my patch in the other bug fixes. The change in there is small enough that if we need this fixed ASAP I can extract it to land without the other changes, but if this is held to Nightly for a bit then we can probably wait for that stack to land as it is nearly ready.

Comment 10

[Harshit Sohaney [:hsohaney]]

I think we're okay waiting for your patch to land while this dialog is nightly only.

Comment 11

[Dão Gottwald [:dao]]

Should be fixed by bug 1875384, bug 1835869 will further improve this.