1875670 - Bugzilla comment with lots of emojis checkerboards quite bad while scrolling (and is fixed with COLR disabled)

Status: RESOLVED FIXED

(Core :: Graphics: Text, enhancement)

Description

[Mayank Bansal]

Go to https://bugzilla.mozilla.org/show_bug.cgi?id=1492605
Scroll down.

AR: as you scroll down, the first comment ha lots of emojis. The page will checkerboard.
ER: Not so

COLR enabled: https://share.firefox.dev/48GJRH0
COLR disabled: https://share.firefox.dev/3SrrHDm

Chrome does not checkerboard.

Comment 1

[Mayank Bansal]

This is probably a known "rendering lots of COLR stuff is currently slower in Firefox" issue. Feel free to dupe to existing bugs.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1875670 - Create a refcounted object for resolved color-font palette, instead of just a bare nsTArray. r=#gfx-reviewers

This does not change behavior for users; it is preparation for the
following patch, which will want the ability to hold an additional
strong reference to a resolved palette. So we can no longer just own it
via a UniquePtr; we make it a RefPtr instead.

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1875670 - Add a cache for rasterized COLRv1 glyphs, because fully redrawing them on each use can be expensive. r=#gfx-reviewers

This substantially improves performance when lots of repeated Segoe UI
Emoji (Win11) glyphs are present, because they're quite expensive to
render "from scratch" every time. (Other COLRv1 fonts will tend to
benefit somewhat as well, though not all are as complex/expensive to
paint as the Segoe UI Emoji glyphs.)

Here's a profile of scrolling up and down a couple of times on the page
https://bugzilla.mozilla.org/show_bug.cgi?id=1492605 without this patch:
https://share.firefox.dev/3Slvrox

With this patch added, the profile looks vastly better:
https://share.firefox.dev/3OjzEb5

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e856837a7620
Create a refcounted object for resolved color-font palette, instead of just a bare nsTArray. r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/7a928b432ee6
Add a cache for rasterized COLRv1 glyphs, because fully redrawing them on each use can be expensive. r=gfx-reviewers,lsalzman

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing build bustage at include/mozilla/gfx/FontPaletteCache.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/c3f86949a2750d2a3c0d5fd27c923ffeb08ad7b0

Push with failures

Failure log -> /builds/worker/workspace/obj-build/dist/include/mozilla/gfx/FontPaletteCache.h(29,37): error: implicit instantiation of undefined template 'nsTArray<mozilla::gfx::sRGBColor>'

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c61f793c65da
Create a refcounted object for resolved color-font palette, instead of just a bare nsTArray. r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/55747feb0e20
Add a cache for rasterized COLRv1 glyphs, because fully redrawing them on each use can be expensive. r=gfx-reviewers,lsalzman

Comment 7

[Serban Stanca [:SerbanS]]

Backed out for causing build bustages.

• Backout link
• Push with failures
• Failure Log
• Failure line: gmake[4]: *** [/builds/worker/checkouts/gecko/config/makefiles/rust.mk:537: force-cargo-test-run] Error 101

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/649109bd35ad
Create a refcounted object for resolved color-font palette, instead of just a bare nsTArray. r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/bfaba1a0d7ab
Add a cache for rasterized COLRv1 glyphs, because fully redrawing them on each use can be expensive. r=gfx-reviewers,lsalzman

Comment 9

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1875670 - followup - fix build failure in fuzz/TestCOLRv1.cpp.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f45af2a9170
followup - fix build failure in fuzz/TestCOLRv1.cpp. r=fix CLOSED TREE

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/649109bd35ad
https://hg.mozilla.org/mozilla-central/rev/bfaba1a0d7ab
https://hg.mozilla.org/mozilla-central/rev/8f45af2a9170

Comment 12

[Mayank Bansal]

The improvement is dramatic in the latest Nightly: https://share.firefox.dev/3SNdEbC