Context menus should not eat clicks outside themselves

RESOLVED FIXED

Status

()

RESOLVED FIXED
16 years ago
10 years ago

People

(Reporter: dean_tessman, Assigned: aaronlev)

Tracking

Trunk
x86
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
From bug 66834, context menus should also not eat clicks outside themselves. 
This is Windows-specific, based on bug 66834 comment 77.

Comment 1

16 years ago
I strongly agree, most un-windows-like :)  And inconsistent with Netscape 4.x.

Is this bug just for right-click menus or for all menus?
(Reporter)

Comment 2

16 years ago
Ian: bug 66834 fixed menus off the menu bar.  This bug is just for context menus.

Comment 3

16 years ago
Hey you're right, its fixed for the menu bar.  That's great news :)
(Assignee)

Comment 4

16 years ago
Should context menus never eat clicks, on any platform? I don't think they
should. Please correct me if I'm wrong.
(Assignee)

Comment 5

16 years ago
Sorry, I wasn't reading correctly. Windows only.
(Assignee)

Comment 6

16 years ago
Created attachment 110806 [details] [diff] [review]
Treat xul:popupset like xul:menu, for purposes of determining click consumption

Jesse, does this patch help with the Phoenix forms autocomplete?
(Assignee)

Updated

16 years ago
Attachment #110806 - Flags: review?(dean_tessman)
(Reporter)

Comment 7

16 years ago
Comment on attachment 110806 [details] [diff] [review]
Treat xul:popupset like xul:menu, for purposes of determining click consumption

I like simple.	r=me
Attachment #110806 - Flags: review?(dean_tessman) → review+
(Assignee)

Comment 8

16 years ago
Comment on attachment 110806 [details] [diff] [review]
Treat xul:popupset like xul:menu, for purposes of determining click consumption

Seeking sr= for tiny patch
Attachment #110806 - Flags: superreview?(alecf)

Comment 9

16 years ago
Comment on attachment 110806 [details] [diff] [review]
Treat xul:popupset like xul:menu, for purposes of determining click consumption

sr=alecf
hope this got lots of testing! :)
Attachment #110806 - Flags: superreview?(alecf) → superreview+
(Assignee)

Comment 10

16 years ago
checked in
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 11

16 years ago
Yes, this fixed Phoenix form autocomplete (tested Phoenix 01/07 nightly).  I
think it also fixed Phoenix address bar autocomplete and Mozilla address bar
autocomplete (bug 66834).

Comment 12

16 years ago
Right-click menus no longer seem to eat clicks, but the menus from personal
toolbar folders (including bookmarks) still do.  Build ID 2003011405.  Win98.

Comment 13

16 years ago
Context menus in MailNews still eat clicks.  Should I raise that as a separate bug?

Updated

10 years ago
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: shrir → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.