1875817 - Translations Integration Toolbar Showing

Status: RESOLVED FIXED

(Fenix :: Translations, enhancement, P2)

Description

[Olivia Hall [:olivia]]

This bug is to connect the logic to only show the Translations toolbar when a translation is expected.

The toolbar should be affiliated with the action TranslateExpectedAction, which is connected to the delegate caused by the GeckoView engine under onTranslateExpected.

Comment 1

[Olivia Hall [:olivia]]

(Toolbar button should also continue to stay behind development flag as well.)

Comment 2

[Olivia Hall [:olivia]]

Be sure to consult this Figma thread for more information and likely this file on some of the scenarios.

Comment 3

[Olivia Hall [:olivia]]

Data model flag is isExpectedTranslate.

Comment 4

[Olivia Hall [:olivia]]

Testing Notes:

• This flow is very dependent on the device and app language.

Show Toolbar flow untranslated:

• Navigate to a page with a supported detected language, that is not a user preferred language (app or OS language).
• The toolbar icon should show.

No Toolbar flow untranslated:
A:

• Navigate to a page with a supported detected language, that is the user preferred language (app or OS language).
• The toolbar icon should not show.

B:

• Navigate to a page with an unsupported detected language, that is not the user preferred language (app or OS language).
• The toolbar icon should not show.

Show Toolbar flow translated:

• The toolbar icon should always show when in the translated state, independent of how the translation occurred.

Comment 5

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1875817 - Translations Integration Toolbar Showing (#5600)

Comment 6

[BMO Github Automation]

Authored by https://github.com/iorgamgabriel
https://github.com/mozilla-mobile/firefox-android/commit/baa7120c95c59f5792ba6d54873e101321d5d7d7
[main] Bug 1875817 - Translations Integration Toolbar Showing