1875839 - Remove manual page load events from the Glean Debug Ping Viewer

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, task, P1)

Description

[Bruno Rosa [:brosa]]

This is an outcome of https://bugzilla.mozilla.org/show_bug.cgi?id=1874884.

We currently have two different methods of collecting page loads in the Debug Ping Viewer

1. Manual page load events in page components
2. Built-in Glean.js page load events hooked into react-router

We verified in the bug linked above that the counts are more correct for the built-in page loads, so we should remove the manual events.

Comment 1

[Alessio Placitelli [:Dexter]]

Hey Abhishek, is this something you could squeeze in?

Comment 2

[Abhishek]

I can create a PR to do this. This should be pretty straightforward. Then I can deploy the latest DPV with this change. Assigning it to myself.

Btw, which one has higher priority, this one or https://bugzilla.mozilla.org/show_bug.cgi?id=1883593? So that I can plan accordingly.

Comment 3

[Alessio Placitelli [:Dexter]]

(In reply to Abhishek from comment #2)

Btw, which one has higher priority, this one

This one is definitely lower priority

Comment 4

[Abhishek]

Great. Then I will prioritize it accordingly.

Comment 5

[BMO Github Automation]

Attachment: [mozilla/debug-ping-view] [Bug 1875839] Remove app defined page load events (#165)

Comment 6

[Abhishek]

Attachment: [mozilla/debug-ping-view] [Bug 1875839] Remove app defined page load events (#165)

Comment 7

[Abhishek]

PR is approved and merged. Deploying it to dev and prod now.

Comment 8

[Abhishek]

Latest DPV deployed to dev and prod successfully. Things are working as expected on dev and prod.
Marking this ticket as resolved.