1875866 - [wpt-sync] Sync PR 44121 - Add layers variant to colorMatrix filter tests

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44121 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44121
Details from upstream follow.

Andres Ricardo Perez <[e-mail]> wrote:

Add layers variant to colorMatrix filter tests

Modified the existing generated tests for the colorMatrix filter, to
also generate variants that apply them via layers.

The assertions for the cases that should throw errors were separetd into
a different test as they can be done in a single generator entry.

The existing tests used asserts on pixel data. They were converted into
reference tests using multidimensional variants.

Bug: 1396372
Change-Id: Id5ae567ec9470db24d043416e4e263fe6f9bfecc
Reviewed-on: https://chromium-review.googlesource.com/5213971
WPT-Export-Revision: 707d5f229be0194e458c0ef3d39cb9f6c172dfa8

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2319a1cfff8663a1f0099e07fd9724dd6f44f36

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=3eeb67f599260ea675a8a57c9335ae6c17c3872f

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=57d7dd55c7f96ff56f3084cd3d3dcb169378c575

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 6 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests and 1 subtests

Status Summary

Firefox

OK : 6
FAIL: 6

Chrome

OK : 6
PASS: 6

Safari

OK : 6
FAIL: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/canvas/element/filters/2d.filter.canvasFilterObject.colorMatrix.tentative.html [wpt.fyi]
  • Test the functionality of ColorMatrix filters: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/element/filters/2d.filter.layers.colorMatrix.html [wpt.fyi]
  • Test the functionality of ColorMatrix filters: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.colorMatrix.tentative.html [wpt.fyi]
  • Test the functionality of ColorMatrix filters: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/offscreen/filters/2d.filter.canvasFilterObject.colorMatrix.tentative.worker.html [wpt.fyi]
  • Test the functionality of ColorMatrix filters: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/offscreen/filters/2d.filter.layers.colorMatrix.html [wpt.fyi]
  • Test the functionality of ColorMatrix filters: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/offscreen/filters/2d.filter.layers.colorMatrix.worker.html [wpt.fyi]
  • Test the functionality of ColorMatrix filters: FAIL (Chrome: PASS, Safari: FAIL)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e6e52855af5
[wpt PR 44121] - Add layers variant to colorMatrix filter tests, a=testonly
https://hg.mozilla.org/integration/autoland/rev/71937078873e
[wpt PR 44121] - Update wpt metadata, a=testonly

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/9e6e52855af5
https://hg.mozilla.org/mozilla-central/rev/71937078873e