1875891 - Crash in [@ java.nio.charset.MalformedInputException: at java.nio.charset.CoderResult.throwException(CoderResult.java)]

Status: RESOLVED FIXED

(Firefox for Android :: General, defect)

Description

[Donal Meehan [:dmeehan]]

Crash report: https://crash-stats.mozilla.org/report/index/096636dd-088b-46fe-b870-a24300240122

Comment 1

[Donal Meehan [:dmeehan]]

:amejia could this be triaged to get it in front of someone for investigation?
The volume is currently low, but it's new in 122.0.

Comment 2

[Arturo Mejia [:amejia]]

👋
Brought the ticket to application services engineering channel, hopefully someone from the team could start the investigation soon.

Comment 3

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1875891 - Adding MalformedInputException to catch list of handlePlacesExceptions. (#5278)

Comment 4

[BMO Github Automation]

Authored by https://github.com/Amejia481
https://github.com/mozilla-mobile/firefox-android/commit/d10752fb45acbce2ac9291ab6cbee5e2262e6c06
[main] Bug 1875891 - Adding MalformedInputException to catch list of handlePlacesExceptions.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:amejia, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox123 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Arturo Mejia [:amejia]]

Comment on attachment 9376234 [details] [review]
[mozilla-mobile/firefox-android] Bug 1875891 - Adding MalformedInputException to catch list of handlePlacesExceptions. (#5278)

Beta/Release Uplift Approval Request

• User impact if declined: We will still see crashes
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce: n/a
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We are only capturing an uncaught exception.
• String changes made/needed:
• Is Android affected?: Yes

Comment 7

[Arturo Mejia [:amejia]]

Comment on attachment 9376234 [details] [review]
[mozilla-mobile/firefox-android] Bug 1875891 - Adding MalformedInputException to catch list of handlePlacesExceptions. (#5278)

Beta/Release Uplift Approval Request

• User impact if declined: We will still see crashes.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce: n/a
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We are only capturing an uncaught exception.
• String changes made/needed:
• Is Android affected?: Yes

Comment 8

[Pascal Chevrel:pascalc]

Arturo, could you please make PR's that are for the target branches with mergify? Thanks
https://github.com/mozilla-mobile/firefox-android/blob/main/docs/shared/uplift_guide.md#betarelease-uplift-steps

Comment 9

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1875891 - Adding MalformedInputException to catch list of handlePlacesExceptions. (backport #5278) (#5338)

Comment 10

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1875891 - Adding MalformedInputException to catch list of handlePlacesExceptions. (backport #5278) (#5339)

Comment 11

[Donal Meehan [:dmeehan]]

Comment on attachment 9376234 [details] [review]
[mozilla-mobile/firefox-android] Bug 1875891 - Adding MalformedInputException to catch list of handlePlacesExceptions. (#5278)

Moving beta and release uplift requests to the Fx123 and Fx122 backports

Comment 12

[BMO Github Automation]

Authored by https://github.com/mergify[bot]
https://github.com/mozilla-mobile/firefox-android/commit/a715549e4ba13c153b3217f30afb93bf00ccc882
[releases_v123] Bug 1875891 - Adding MalformedInputException to catch list of handlePlacesExceptions. (backport #5278) (#5338)

Comment 13

[Donal Meehan [:dmeehan]]

Comment on attachment 9376829 [details] [review]
[mozilla-mobile/firefox-android] Bug 1875891 - Adding MalformedInputException to catch list of handlePlacesExceptions. (backport #5278) (#5339)

Approved for Fenix/Focus 122.0.1

Comment 14

[BMO Github Automation]

Authored by https://github.com/Amejia481
https://github.com/mozilla-mobile/firefox-android/commit/94e8fe9ea152ec9a1ad7d38d694cc687511ac741
[releases_v122] Bug 1875891 - Adding MalformedInputException to catch list of handlePlacesExceptions.