1876109 - Update font size and weight for synced tabs device name headers in Firefox View

Status: RESOLVED FIXED

(Firefox :: Firefox View, task, P3)

Description

[Kelly Cochrane [:kcochrane]]

In order to create more visual distinction between synced tabs device name headers with other headers in Firefox View, we should adjust the font-weight to 600 and decrease font-size from 1em to 0.9em.

Comment 1

[Alex Kordas]

Attachment: Bug 1876109 - Adjust font-weight and font-size for synced tabs device headers in Firefox View. ?

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ea9adc9b7ef3
https://hg.mozilla.org/integration/autoland/rev/84a4ad9c5aaf
Adjust font-weight and font-size for synced tabs device headers in Firefox View. ? r=desktop-theme-reviewers,fxview-reviewers,sfoster,dao

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/852e1eafc9c4
https://hg.mozilla.org/integration/autoland/rev/56431131959c
Revert "Bug 1876109 - Adjust font-weight and font-size for synced tabs device headers in Firefox View. ? r=desktop-theme-reviewers,fxview-reviewers,sfoster,dao" for bc failure on browser_parsable_css.js

Comment 4

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failure on browser_parsable_css.js

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/56431131959c1917d219757d81742b0e74d40fb0
Log link: https://treeherder.mozilla.org/logviewer?job_id=535820127&repo=autoland&task=eNaSgsnRTJKVul7XS_mEBA.0&lineNumber=2240

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:sclements, since the bug has recent activity, could you have a look please?

For more information, please visit BugBot documentation.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Comment 7

[Osoble]

Hi can i work on this?

Comment 8

[Noble Chinonso]

Hi, i would like to work on this

Comment 9

[Noble Chinonso]

Hi, I've submitted a patch for this bug: https://phabricator.services.mozilla.com/D289111. I looked at the previous patch and the backout reason, so the fix also removes the unused --fxview-card-header-font-weight variable from firefoxview.css and updates the font-size to var(--font-size-small) as suggested in the earlier review.

Comment 10

[Kelly Cochrane [:kcochrane]]

Yeah since :Osoble requested to work on this first, we're going to go forward with their patch.

Comment 11

[Noble Chinonso]

Attachment: Bug 1876109 - Update font size for synced tabs device headers and remove unused CSS variable

Comment 12

[Noble Chinonso]

(In reply to Kelly Cochrane [:kcochrane] from comment #10)

Yeah since :Osoble requested to work on this first, we're going to go forward with their patch.

Thanks for the clarification Kelly. I'll let Osoble take this one forward.

Comment 13

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 9556103 [details]
Bug 1876109 - Update font size for synced tabs device headers and remove unused CSS variable

Marking Noble's patch obsolete per comment #12

Comment 14

[Sam Foster [:sfoster] (he/him)]

Osoble, can you update here if you are working on a patch for this bug? I see you commented on a few other bugs and if you are working on another issue I'd like to open this back up to other contributors.

Comment 15

[Osoble]

Hi sam, i am currently working on a patch for this bug but it's just a little late where i am, I'll have this completed sometime tomorrow if all goes well.

Comment 16

[Osoble]

Attachment: Bug 1876109 - Update font size and weight for synced tabs device name headers in Firefox View r?sfoster

Comment 17

[Osoble]

Hi Sam, i've left a comment on Phabricator about an issue i'm having with ./mach lint

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2737ef1f3888
https://hg.mozilla.org/integration/autoland/rev/33ac2677747c
Update font size and weight for synced tabs device name headers in Firefox View r=sfoster,desktop-theme-reviewers,fxview-reviewers

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a8f262f81628
https://hg.mozilla.org/integration/autoland/rev/88bc3415b37d
Revert "Bug 1876109 - Update font size and weight for synced tabs device name headers in Firefox View r=sfoster,desktop-theme-reviewers,fxview-reviewers" for causing bc failures @browser_parsable_css.js.

Comment 20

[agoloman]

Backed out for causing bc failures @browser_parsable_css.js.

• Backout link
• Push with failures
• Failure Log

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/54cc36446c6a
https://hg.mozilla.org/integration/autoland/rev/ab55e81123c8
Update font size and weight for synced tabs device name headers in Firefox View r=sfoster,desktop-theme-reviewers,fxview-reviewers

Comment 22

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/ab55e81123c8

Comment 23

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/ab55e81123c8