Update js-string-builtins implementation for recent changes
Categories
(Core :: JavaScript: WebAssembly, task, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox125 | --- | fixed |
People
(Reporter: rhunt, Assigned: rhunt)
References
(Blocks 1 open bug)
Details
Attachments
(5 files)
https://github.com/WebAssembly/js-string-builtins/pull/14
https://github.com/WebAssembly/js-string-builtins/pull/20
^ landed in the last two weeks with some naming and type signature tweaks.
Assignee | ||
Comment 1•3 months ago
|
||
We need to be able to have a type signature such as:
(func (param (ref (array i16))))
In our builtin methods to support JS-string-builtins.
This commit:
- Adds wasm::StaticTypeDefs for process-lifetime wasm::TypeDef*
- Adds wasm::BuiltinModuleFuncs for process-lifetime BuiltinModuleFunc
- Change GenerateBuiltinModules.py to accept type syntax
- For generating SymbolicAddressSignature, we just need a MIRType
- For BuiltinModuleFunc, we generate a ValType
- The signature for JS-string-builtin methods that need types are fixed
Assignee | ||
Comment 2•3 months ago
|
||
These were missing in the initial implementation.
Depends on D199387
Assignee | ||
Comment 3•3 months ago
|
||
Depends on D199388
Assignee | ||
Comment 4•3 months ago
|
||
This is difficult to test because all strings are limited to less than
2GiB of characters, and negative indices are not valid, so any difference
between unsigned and signed will trap either way.
The one case I can think of, I added a test for.
Depends on D199389
Assignee | ||
Comment 5•3 months ago
|
||
WebAssembly.validate can take feature options, like enabling
js-string-builtins. This is useful for feature detection.
The test is extended to use it.
Depends on D199390
Pushed by rhunt@eqrion.net: https://hg.mozilla.org/integration/autoland/rev/b31c3404c4c1 wasm: Let builtin module funcs reference type definitions in signature. r=yury https://hg.mozilla.org/integration/autoland/rev/1f676c723bba wasm: Add js-string-builtin cast and test builtins. r=yury https://hg.mozilla.org/integration/autoland/rev/f810b05292bc wasm: Update names for latest js-string-builtin changes. r=yury https://hg.mozilla.org/integration/autoland/rev/29c12bdc7e54 wasm: js-string-builtin arguments are unsigned. r=yury https://hg.mozilla.org/integration/autoland/rev/88c1141d96c6 wasm: Validate accepts feature options. r=yury
Comment 7•2 months ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b31c3404c4c1
https://hg.mozilla.org/mozilla-central/rev/1f676c723bba
https://hg.mozilla.org/mozilla-central/rev/f810b05292bc
https://hg.mozilla.org/mozilla-central/rev/29c12bdc7e54
https://hg.mozilla.org/mozilla-central/rev/88c1141d96c6
Description
•