1876148 - Update js-string-builtins implementation for recent changes

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task, P1)

Description

[Ryan Hunt [:rhunt]]

https://github.com/WebAssembly/js-string-builtins/pull/14
https://github.com/WebAssembly/js-string-builtins/pull/20

^ landed in the last two weeks with some naming and type signature tweaks.

Comment 1

[Ryan Hunt [:rhunt]]

Attachment: Bug 1876148 - wasm: Let builtin module funcs reference type definitions in signature. r?yury

We need to be able to have a type signature such as:
(func (param (ref (array i16))))
In our builtin methods to support JS-string-builtins.

This commit:

• Adds wasm::StaticTypeDefs for process-lifetime wasm::TypeDef*
• Adds wasm::BuiltinModuleFuncs for process-lifetime BuiltinModuleFunc
• Change GenerateBuiltinModules.py to accept type syntax
  • For generating SymbolicAddressSignature, we just need a MIRType
  • For BuiltinModuleFunc, we generate a ValType
• The signature for JS-string-builtin methods that need types are fixed

Comment 2

[Ryan Hunt [:rhunt]]

Attachment: Bug 1876148 - wasm: Add js-string-builtin cast and test builtins. r?yury

These were missing in the initial implementation.

Depends on D199387

Comment 3

[Ryan Hunt [:rhunt]]

Attachment: Bug 1876148 - wasm: Update names for latest js-string-builtin changes. r?yury

Depends on D199388

Comment 4

[Ryan Hunt [:rhunt]]

Attachment: Bug 1876148 - wasm: js-string-builtin arguments are unsigned. r?yury

This is difficult to test because all strings are limited to less than
2GiB of characters, and negative indices are not valid, so any difference
between unsigned and signed will trap either way.

The one case I can think of, I added a test for.

Depends on D199389

Comment 5

[Ryan Hunt [:rhunt]]

Attachment: Bug 1876148 - wasm: Validate accepts feature options. r?yury

WebAssembly.validate can take feature options, like enabling
js-string-builtins. This is useful for feature detection.

The test is extended to use it.

Depends on D199390

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b31c3404c4c1
wasm: Let builtin module funcs reference type definitions in signature. r=yury
https://hg.mozilla.org/integration/autoland/rev/1f676c723bba
wasm: Add js-string-builtin cast and test builtins. r=yury
https://hg.mozilla.org/integration/autoland/rev/f810b05292bc
wasm: Update names for latest js-string-builtin changes. r=yury
https://hg.mozilla.org/integration/autoland/rev/29c12bdc7e54
wasm: js-string-builtin arguments are unsigned. r=yury
https://hg.mozilla.org/integration/autoland/rev/88c1141d96c6
wasm: Validate accepts feature options. r=yury

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b31c3404c4c1
https://hg.mozilla.org/mozilla-central/rev/1f676c723bba
https://hg.mozilla.org/mozilla-central/rev/f810b05292bc
https://hg.mozilla.org/mozilla-central/rev/29c12bdc7e54
https://hg.mozilla.org/mozilla-central/rev/88c1141d96c6