1876165 - Create BookmarkList class that internally stays up-to-date to indicate bookmarked open tabs in Fx View

Status: RESOLVED FIXED

(Firefox :: Firefox View, enhancement, P1)

Description

[Kelly Cochrane [:kcochrane]]

Adding this as a follow-up to bug 1857005. In order to ensure bookmarked open tabs are indicated in Fx View properly, we'll need to create a BookmarkList class that internally stays up-to-date (it may be nice to implement it in Places so others could reuse it). This class should query all the open tabs URLs at start or at first access, use observers (bookmark-added, bookmark-removed, bookmark-url-changed at least) to keep the list up-to-date, and query for new entries as new tabs will be added to the list

In doing so, we avoid having to use fetch to check each individual URL which would become costly with 100+ tabs. We should also consider only checking URLs for items rendered within the virtual-list component rather than the entire list of open tabs.

Comment 1

[Jonathan Sudiaman [:jsudiaman]]

Attachment: Bug 1876165 - Create BookmarkList class that internally stays up-to-date to indicate bookmarked open tabs in Fx View r?kcochrane,mak

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bfb6942faf35
Create BookmarkList class that internally stays up-to-date to indicate bookmarked open tabs in Fx View r=mak,fxview-reviewers,places-reviewers,fluent-reviewers,bolsson,sfoster,desktop-theme-reviewers

Comment 4

[Iulian Moraru]

Backed out for causing multiple bc failures.

• Push with failures

• Failure log for failures on browser_tab_list_keyboard_navigation.js

• Failure log for failures on browser_opentabs_tab_indicators.js

• Backout link

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebe362ea0bcd
Create BookmarkList class that internally stays up-to-date to indicate bookmarked open tabs in Fx View r=mak,fxview-reviewers,places-reviewers,fluent-reviewers,bolsson,sfoster,desktop-theme-reviewers

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ebe362ea0bcd