1876178 - Add more specificity on when to record telemetry on reloaded due to a config change (search engine changed, engine-update)

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mandy Cheang [:mcheang][she/her]]

In Bug 1852527, I added telemetry for when the default engine's property is updated. (engine-update).
We discovered that our telemetry is not very specific when it comes to reloading engines due to a config change.

At the moment, when we reload due to a configuration change, we update the engines as they may have changed: engine.updateIfNoNameChange. However, we don't track if any attribute has actually changed from previous, and so we send out an update regardless: #updateFromManifest

We should consider adding more specificity on when we report the telemetry, some options:

1. Only notify when something on the search engine has actually changed
2. when reloading engines, have a special observer notification to indicate that all engines may have changed.

This bug may be a good spike to do during a DragonSlayer - spend a few hours experimenting and seeing what we'd like it to look like, and implement it.

Comment 1

[Stephanie Cunnane [:scunnane]]

Attachment: Bug 1876178 - Improve default search engine changed telemetry. r?Standard8!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55c366ee4422
Improve default search engine changed telemetry. r=Standard8

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out changeset 55c366ee4422 (Bug 1876178) for causing documentation failures

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=55c366ee4422f028170ccb67f2355ef9c0101bdc&selectedTaskRun=JAd8RVr1RtyBu-1adrUojw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=483514893&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/7493a728ca5f93a9ea51ed98390dff1aa36be807

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fcf70a4813d1
Improve default search engine changed telemetry. r=Standard8

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing documentation failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/0f913e6025c10ac90a6f492c27155b8dd78730b5

Push with failures

Failure log -> sphinx.errors.ExtensionError: Handler <function analyze at 0x7fc0809a9d00> for event 'builder-inited' threw an exception (exception: Your code contains multiple documented objects at each of these paths:

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0505e8558933
Improve default search engine changed telemetry. r=Standard8

Comment 7

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/0505e8558933