1876200 - Add message bar to prompt users to disable auto-open

Status: VERIFIED FIXED

(Firefox :: Shopping, enhancement, P1)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Here's the Figma link (screenshots to be added)

Notes:

• the logic is described in the Figma:
  • when the user closes the sidebar 5 times in one session, show this card.
  • if the user clicks either button in the card, don't show it again (set some pref).
  • if the user doesn't click any button in the card, but just navigates away or closes the tab, increment a counter; after 3 tries in a session, don't show it again (set the pref mentioned above).
• I'm not sure message-bar component supports this configuration of buttons; use a shopping-card or whatever as needed
• we'll need a per-session counter of sidebar closes, which could be incremented by click handlers or by adding some logic to an existing pref listener callback. ShoppingUtils is app global, so it's a good place to store this new counter.
• if the message bar is shown, but the user doesn't click either button, we'll need to increment a per-session counter of message bar displays. Again, ShoppingUtils seems like a reasonable spot for the global state that's reset with each session
• because we are past string freeze for 123, we will need to land the new strings in the preview location for shopping, then land a followup patch in a followup bug to move the strings to the permanent location in 124 nightly.

Comment 1

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1876200 - Add keep closed shopping message bar. r=#shopping-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bef075fc0b7f
Add keep closed shopping message bar. r=shopping-reviewers,fluent-reviewers,desktop-theme-reviewers,flod,kpatenio,jules

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

[Tracking Requested - why for this release]: This is part of the auto-open feature we would like to uplift into 123.

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/bef075fc0b7f

Comment 5

[Niklas Baumgardner [:niklas]]

Comment on attachment 9376678 [details]
Bug 1876200 - Add keep closed shopping message bar. r=#shopping-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: If declined, there will be no way for users enrolled into our rediscoverability experiment to modify auto-open behaviour toggled by the pref browser.shopping.experience2023.autoOpen.userEnabled.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Make sure the shopping sidebar is enabled.

1. go to amazon product page
2. close sidebar 5 times via the urlbar button and the close button in the sidebar
   On the fifth close, a message bar will appear
   if nothing is clicked, show the message bar 3 more times total
   if a button is clicked, never show message bar again
   click yes, will never show message bar again, disable auto open and show callout 4

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch is needed for the rediscoverability experiment to modify auto-open behaviour toggled by the pref browser.shopping.experience2023.autoOpen.userEnabled.
• String changes made/needed: no
• Is Android affected?: No

Comment 6

[Pascal Chevrel:pascalc]

Comment on attachment 9376678 [details]
Bug 1876200 - Add keep closed shopping message bar. r=#shopping-reviewers

Approved for 123 beta 8, thanks.

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/84c6bdfd260d

Comment 8

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/84c6bdfd260d

Comment 9

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta 123.0b8 as well as our latest Nightly build.