Closed Bug 1876222 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 44157 - Change requestMethod from USVString to ByteString.

Categories

(Core :: DOM: Service Workers, task, P4)

Product:
Core
Component:
DOM: Service Workers
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
124 Branch
Tracking Flags:
Tracking Status
firefox124 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 44157 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44157
Details from upstream follow.

Yoshisato Yanagisawa <yyanagisawa@chromium.org> wrote:

Change requestMethod from USVString to ByteString.

Since Request API's method is ByteString, requestMethod in the static
routing API should also be aligned with it.

Bug: 1371756
Change-Id: I9ccfaa11c9d45e09579d3c9a43576f8abc9f8c3a
Reviewed-on: https://chromium-review.googlesource.com/5223724
WPT-Export-Revision: 92096d333a7463d9b7cd403644a57a3922e7db82

PR 44157 applied with additional changes from upstream: 89cff6a99291719842e719c82d1968a8b64aa28e
Component: web-platform-tests → DOM: Service Workers
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 14 subtests

Status Summary

Firefox

OK : 2[Gecko-windows11-32-2009-qr-opt] 3[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub]
FAIL: 14[Gecko-windows11-32-2009-qr-opt] 21[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 22[GitHub]

Chrome

OK : 3
PASS: 6
FAIL: 16

Safari

OK : 3
FAIL: 22

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /service-workers/service-worker/tentative/static-router/static-router-invalid-rules.https.html [wpt.fyi]
    • addRoutes should raise for invalid request method.: FAIL (Chrome: PASS, Safari: FAIL)
  • /service-workers/service-worker/tentative/static-router/static-router-main-resource.https.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], SKIP [Gecko-windows11-32-2009-qr-opt] (Chrome: OK, Safari: OK)
    • Main resource load matched with the condition: FAIL (Chrome: FAIL, Safari: FAIL)
    • Main resource load matched with the ignore case condition: FAIL (Chrome: FAIL, Safari: FAIL)
    • Main resource load matched without the ignore case condition: FAIL (Chrome: PASS, Safari: FAIL)
    • Main resource load not matched with the condition: FAIL (Chrome: PASS, Safari: FAIL)
    • Main reosurce load matched with the service worker having multiple rules: FAIL (Chrome: FAIL, Safari: FAIL)
    • Main resource load matched with the cache source: FAIL (Chrome: FAIL, Safari: FAIL)
    • Main resource fallback to the network when there is no cache entry: FAIL (Chrome: FAIL, Safari: FAIL)
  • /service-workers/service-worker/tentative/static-router/static-router-subresource.https.html [wpt.fyi]
    • Subresource load not matched with URLPattern condition: FAIL (Chrome: PASS, Safari: FAIL)
    • Subresource load matched with URLPattern condition: FAIL (Chrome: FAIL, Safari: FAIL)
    • Subresource cross origin load matched with URLPattern condition via constructed object: FAIL (Chrome: FAIL, Safari: FAIL)
    • Subresource load matched with ignoreCase URLPattern condition: FAIL (Chrome: FAIL, Safari: FAIL)
    • Subresource load matched without ignoreCase URLPattern condition: FAIL (Chrome: PASS, Safari: FAIL)
    • Subresource load matched with URLPattern condition via URLPatternInit: FAIL (Chrome: FAIL, Safari: FAIL)
    • Subresource cross origin load not matched with URLPattern condition via URLPatternInit: FAIL (Chrome: FAIL, Safari: FAIL)
    • Subresource load matched with URLPattern condition via string: FAIL (Chrome: FAIL, Safari: FAIL)
    • Subresource cross origin load not matched with URLPattern condition via string: FAIL (Chrome: FAIL, Safari: FAIL)
    • Subresource load matched with RequestMode condition: FAIL (Chrome: FAIL, Safari: FAIL)
    • Subresource load matched with the nested or condition: FAIL (Chrome: FAIL, Safari: FAIL)
    • Subresource load matched with the next or condition: FAIL (Chrome: FAIL, Safari: FAIL)
    • Subresource load not matched with or condition: FAIL (Chrome: PASS, Safari: FAIL)
    • Subresource load matched with the cache source rule: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/31f601817308 [wpt PR 44157] - Change requestMethod from USVString to ByteString., a=testonly https://hg.mozilla.org/integration/autoland/rev/82befa3c131b [wpt PR 44157] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/31f601817308
https://hg.mozilla.org/mozilla-central/rev/82befa3c131b

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox124: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
You need to log in before you can comment on or make changes to this bug.