Closed
Bug 1876227
Opened 2 years ago
Closed 2 years ago
JS demo (https://www.fxhash.xyz/generative/slug/selva-oscura-i ) is 3x slower in Nightly
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
124 Branch
| Tracking | Status | |
|---|---|---|
| firefox124 | --- | fixed |
People
(Reporter: mayankleoboy1, Assigned: anba)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file)
Go to https://www.fxhash.xyz/generative/slug/selva-oscura-i
Nightly: https://share.firefox.dev/498I8Kr (9s)
Chrome: https://share.firefox.dev/3U7H2KD (3s)
|
||
Updated•2 years ago
|
Severity: -- → N/A
Priority: -- → P3
|
Assignee | |
Comment 1•2 years ago
|
||
Based on the script source code and the profile, which has js::jit::IonSetPropertyIC::update as the hottest function, I guess the script first reads an out-of-bounds value on a TypedArray (this is the undefined value) and then writes undefined into the TypedArray again. SetPropIRGenerator::tryAttachSetTypedArrayElement currently only handles numeric inputs, so undefined goes into the VM call slow path.
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•2 years ago
|
||
|
Reporter | |
Updated•2 years ago
|
Flags: needinfo?(mayankleoboy1)
|
|
Reporter | |
Updated•2 years ago
|
Flags: needinfo?(mayankleoboy1)
Pushed by andre.bargull@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/337ba87df12d
Support non-number inputs when assigning to TypedArray elements. r=jandem
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox124:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
|
|
Reporter | |
Comment 5•2 years ago
|
||
Latest profile (2.5s): https://share.firefox.dev/3ScvgvX
There is 3.6x improvement here and we are faster than the competition. Thanks :anba!
|
||
Updated•2 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•