1876297 - Debugger preview popup evaluates `values` as the console helper, not the actual value

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe][PTO - back on October 21]]

Steps to reproduce

1. Navigate to data:text/html,<meta charset=utf8><script>const values = [1,2,3]; debugger</script>
2. Open the debugger
3. Reload the page, the debugger should pause
4. In the opened source, hover values

Expected results

The preview shows that it's an array

Actual results

The preview says that values is a function, which makes me think it returned the console helper (I'm seeing the same issue with $, which is another console helper)

Comment 1

[Alexandre Poirot [:ochameau]]

It was probably meant to be handled by the useInnerBindings flag:
https://searchfox.org/mozilla-central/rev/2c3d657cbba5484ccac44443c4417baed7b5fafb/devtools/server/actors/webconsole/eval-with-debugger.js#203-207
So either we aren't setting this flag, or it doesn't work as expected?

Comment 2

[Nicolas Chevobbe [:nchevobbe][PTO - back on October 21]]

Looks like this was regressed by Bug 1847222

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1847222

Comment 4

[Alexandre Poirot [:ochameau]]

We can't strictly rely on the existing disableBreaks attribute.
We should probably have a new RDP attribute to distinguish frontend evaluation involving console commands.
Only them should enforce overriding local symbols in scope with the console commands.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1876297 - [devtools] Only force overiding local scope variables for frontend commands relying on console commands.

We should probably expose new RDP methods to prevent relying on console evaluations for this.
We would still have some potential issues if the evaluated method is about a JS symbol
whose name is the console command.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d57b721b460
[devtools] Only force overiding local scope variables for frontend commands relying on console commands. r=devtools-reviewers,devtools-backward-compat-reviewers,nchevobbe

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/4d57b721b460

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:ochameau, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox123 to wontfix.

For more information, please visit BugBot documentation.