Closed Bug 1876300 Opened 2 years ago Closed 1 years ago

Make it possible to check linker flags using configure mechanism

Categories

(Firefox Build System :: General, task)

Product:
Firefox Build System
Component:
General
Type:
task

Tracking

(firefox124 fixed)

Status:
RESOLVED FIXED
Milestone:
124 Branch
Tracking Flags:
Tracking Status
firefox124 --- fixed

People

(Reporter: sergesanspaille, Assigned: sergesanspaille)

References

Details

Attachments

(1 file)

Bug 1876300 - Introduce linker checks to moz.configure r=glandium!
48 bytes, text/x-phabricator-request
Details | Review

We don't have an equivalent to try_compile for the linker.

Attachment #9376218 - Attachment description: WIP: Bug 1876300 - Introduce linker checks to moz.configure → Bug 1876300 - Introduce linker checks to moz.configure r=glandium
Attachment #9376218 - Attachment is obsolete: true
Attachment #9376218 - Attachment is obsolete: false
Pushed by sguelton@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7c3f969f4730 Introduce linker checks to moz.configure r=glandium

Backed out for causing multiple failures on Linux asan opt

[task 2024-02-06T11:12:33.635Z] 11:12:33    ERROR -  ==1324==ERROR: AddressSanitizer: odr-violation (0x559063d820c0):
[task 2024-02-06T11:12:33.656Z] 11:12:33     INFO -    [1] size=40 'vtable for std::thread::_State' /builds/worker/checkouts/gecko/build/unix/stdc++compat/stdc++compat.cpp
[task 2024-02-06T11:12:33.656Z] 11:12:33     INFO -    [2] size=40 'vtable for std::thread::_State' /builds/worker/checkouts/gecko/build/unix/stdc++compat/stdc++compat.cpp
[task 2024-02-06T11:12:33.656Z] 11:12:33     INFO -  These globals were registered at these points:
[task 2024-02-06T11:12:33.656Z] 11:12:33     INFO -    [1]:
[task 2024-02-06T11:12:33.659Z] 11:12:33     INFO -      #0 0x559063b014a6 in __asan_register_globals /builds/worker/fetches/llvm-project/compiler-rt/lib/asan/asan_globals.cpp:365:3
[task 2024-02-06T11:12:33.660Z] 11:12:33     INFO -      #1 0x559063d7e81e in asan.module_ctor stdc++compat.cpp
[task 2024-02-06T11:12:33.660Z] 11:12:33     INFO -      #2 0x559063d7e90c in __libc_csu_init (/builds/worker/workspace/build/tests/bin/xpcshell+0x35f90c)
[task 2024-02-06T11:12:33.661Z] 11:12:33     INFO -    [2]:
[task 2024-02-06T11:12:33.661Z] 11:12:33     INFO -      #0 0x559063b014a6 in __asan_register_globals /builds/worker/fetches/llvm-project/compiler-rt/lib/asan/asan_globals.cpp:365:3
[task 2024-02-06T11:12:33.662Z] 11:12:33     INFO -      #1 0x7f47719f7bfe in asan.module_ctor stdc++compat.cpp
[task 2024-02-06T11:12:33.663Z] 11:12:33     INFO -      #2 0x7f47718c7782  (/lib64/ld-linux-x86-64.so.2+0x10782) (BuildId: 822d3943c4bb51a173776d69a167a71a31522761)
[task 2024-02-06T11:12:33.663Z] 11:12:33     INFO -  ==1324==HINT: if you don't care about these errors you may set ASAN_OPTIONS=detect_odr_violation=0
[task 2024-02-06T11:12:33.664Z] 11:12:33     INFO -  SUMMARY: AddressSanitizer: odr-violation: global 'vtable for std::thread::_State' at /builds/worker/checkouts/gecko/build/unix/stdc++compat/stdc++compat.cpp
[task 2024-02-06T11:12:33.664Z] 11:12:33     INFO -  ==1324==ABORTING
[task 2024-02-06T11:14:03.811Z] 11:14:03    ERROR - TEST-UNEXPECTED-FAIL | runtests.py | Timed out while waiting for server startup.
Flags: needinfo?(sguelton)
Attachment #9376218 - Attachment description: Bug 1876300 - Introduce linker checks to moz.configure r=glandium → Bug 1876300 - Introduce linker checks to moz.configure r=glandium!
Pushed by sguelton@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e8583c0ab2fe Introduce linker checks to moz.configure r=glandium

https://hg.mozilla.org/mozilla-central/rev/e8583c0ab2fe

Status: NEW → RESOLVED
Closed: 1 years ago
status-firefox124: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
Flags: needinfo?(sguelton)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: