1876342 - Modify Firefox to register itself as a native messaging client for Chrome for the Dual Browser extensions on Windows

Status: RESOLVED FIXED

(Firefox :: Shell Integration, task, P3)

Description

[Michael Hughes]

For the Chromium dual browser extension to work (to launch a site in Firefox), there needs to be a mechanism to determine if Firefox is installed and registered as a handler for the firefox: and firefox-private: protocols. The Dual Browser extension will attempt to connect to a native messaging client, which will return an error if the native messaging client is not registered, indicating Firefox isn't installed.

So, Firefox needs to register itself as the native message handler of this type, in the same places in the code that it registers itself as the handler for the above protocols.

https://developer.chrome.com/docs/apps/nativeMessaging/#native-messaging-host-location

Comment 1

[Nipun Shukla]

Attachment: Bug 1876342 - Added Windows native messaging host registration for Chromium r=mhughes

Comment 2

[Nipun Shukla]

Attachment: WIP: Bug 1876342 - Added tests for Windows native messaging host registry key creation r=robwu,mhughes

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9607fd6786bb
Added Windows native messaging host registration for Chromium r=mhughes,robwu,nalexander

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/9607fd6786bb

Comment 5

[Nipun Shukla]

Attachment: Bug 1876342 - Added tests for Windows native messaging registry key creation r=robwu,mhughes

Depends on D205485

Comment 6

[Rob Wu [:robwu]]

Because the bugs have been filed without any description, nor links back to the original bugs, I am copy-pasting the message I put on Slack before, with bug references.

The patches with the Native Messaging host has landed in Firefox, behind the browser.firefoxbridge.enabled pref, off by default. The patch stack that lists the nativeMessaging host IDs and the pref is at https://bugzilla.mozilla.org/show_bug.cgi?id=1876344

There should be a separate bug about setting the pref to true by default.

I cannot find this bug, has it ever been filed?

Before doing so, two more patches should land: (1) limiting the patch to the default profile directory by default

bug 1885385

(2) unit tests for registry changes (so that the unit tests don't pollute the registry of developers/CI)

bug 1885386

P.S. shouln't this bug and bug 1876344 be in the Firefox::Shell Integration component since neither patch touches the installer?

Comment 7

[Nipun Shukla]

I've just filed that bug and linked it here. Also changed the two bugs you mentioned to Shell Integration. I set it to the Installer component when the original registration method was the installer rather than just the idle task.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0920d60e8a95
Added tests for Windows native messaging registry key creation r=robwu,mhughes

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/0920d60e8a95