1876369 - [wpt-sync] Sync PR 44174 - DOM: Implement the `takeUntil()` Observable operator

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44174 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44174
Details from upstream follow.

Dominic Farolino <[e-mail]> wrote:

DOM: Implement the takeUntil() Observable operator

This CL implements the semantics specified in
https://wicg.github.io/observable/#dom-observable-takeuntil.

R=[e-mail]

Bug: 1485981
Change-Id: Ifeba3baf10917191c0f0b2b70473d02e67738f79

Reviewed-on: https://chromium-review.googlesource.com/5228477
WPT-Export-Revision: a8fbdaed7c359a1fc8d27194875b5692e99b61aa

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=82fd0ffaa68d50ab8231ce3687513a9c274ade79

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 2 subtests

Status Summary

Firefox

OK : 3
FAIL: 24

Chrome

OK : 3
FAIL: 24

Safari

OK : 3
FAIL: 24

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /dom/observable/tentative/observable-takeUntil.any.worker.html [wpt.fyi]
  • takeUntil subscribes to source Observable and mirrors it uninterrupted: FAIL (Chrome: FAIL, Safari: FAIL)
  • takeUntil subscribes to notifier: FAIL (Chrome: FAIL, Safari: FAIL)
  • takeUntil: notifier next() unsubscribes to notifier: FAIL (Chrome: FAIL, Safari: FAIL)
  • takeUntil: notifier error() unsubscribes to notifier: FAIL (Chrome: FAIL, Safari: FAIL)
  • takeUntil: notifier next() unsubscribes from notifier & source observable: FAIL (Chrome: FAIL, Safari: FAIL)
  • takeUntil()'s AbortSignal unsubscribes from notifier & source observable: FAIL (Chrome: FAIL, Safari: FAIL)
  • takeUntil: source never subscribed to when notifier synchronously emits a value: FAIL (Chrome: FAIL, Safari: FAIL)
  • takeUntil: source never subscribed to when notifier synchronously emits error: FAIL (Chrome: FAIL, Safari: FAIL)
  • takeUntil: source is uninterrupted when notifier completes, even synchronously: FAIL (Chrome: FAIL, Safari: FAIL)
  • takeUntil() mirrors the source Observable until its first next() value: FAIL (Chrome: FAIL, Safari: FAIL)
  • takeUntil: notifier calls Subscriber#error() twice; second goes to global error handler: FAIL (Chrome: FAIL, Safari: FAIL)
• /dom/observable/tentative/observable-takeUntil.any.html [wpt.fyi]
  • takeUntil subscribes to source Observable and mirrors it uninterrupted: FAIL (Chrome: FAIL, Safari: FAIL)
  • takeUntil subscribes to notifier: FAIL (Chrome: FAIL, Safari: FAIL)
  • takeUntil: notifier next() unsubscribes to notifier: FAIL (Chrome: FAIL, Safari: FAIL)
  • takeUntil: notifier error() unsubscribes to notifier: FAIL (Chrome: FAIL, Safari: FAIL)
  • takeUntil: notifier next() unsubscribes from notifier & source observable: FAIL (Chrome: FAIL, Safari: FAIL)
  • takeUntil()'s AbortSignal unsubscribes from notifier & source observable: FAIL (Chrome: FAIL, Safari: FAIL)
  • takeUntil: source never subscribed to when notifier synchronously emits a value: FAIL (Chrome: FAIL, Safari: FAIL)
  • takeUntil: source never subscribed to when notifier synchronously emits error: FAIL (Chrome: FAIL, Safari: FAIL)
  • takeUntil: source is uninterrupted when notifier completes, even synchronously: FAIL (Chrome: FAIL, Safari: FAIL)
  • takeUntil() mirrors the source Observable until its first next() value: FAIL (Chrome: FAIL, Safari: FAIL)
  • takeUntil: notifier calls Subscriber#error() twice; second goes to global error handler: FAIL (Chrome: FAIL, Safari: FAIL)
• /dom/observable/tentative/observable-takeUntil.window.html [wpt.fyi]
  • takeUntil(): notifier Observable detaches document before source Observable would be subscribed to: FAIL (Chrome: FAIL, Safari: FAIL)
  • takeUntil(): Source and notifier internal observers do not crash in a detached document: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72f4d6f8bc4f
[wpt PR 44174] - DOM: Implement the `takeUntil()` Observable operator, a=testonly
https://hg.mozilla.org/integration/autoland/rev/ef2bff016808
[wpt PR 44174] - Update wpt metadata, a=testonly

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/72f4d6f8bc4f
https://hg.mozilla.org/mozilla-central/rev/ef2bff016808