1876427 - [wpt-sync] Sync PR 44182 - [EditContext] Allow backwards selection

Status: RESOLVED FIXED

(Core :: DOM: Editor, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44182 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44182
Details from upstream follow.

Dan Clark <[e-mail]> wrote:

[EditContext] Allow backwards selection

Per resolution of https://github.com/w3c/edit-context/issues/81,
EditContext should allow the author to set a backwards selection.

In addition to removing the restriction in updateSelection(),
various parts of EditContext need to be udpated to handle a backwards
selection. In most cases this consists using helper functions that
ensure the forward version of the selection range is used.

Test cases are added, including for forward-selection scenarios
that were missing.

Some backspace/delete tests were removed from
edit-context-dom-mutation.html since edit-context-input-tentative.html
already has similar tests.

Bug: 999184
Change-Id: Ibed0c63981d570418810339ce947678e8a809c1c
Reviewed-on: https://chromium-review.googlesource.com/5235427
WPT-Export-Revision: 05b86fcb0b64f9992dc3f5876e93e6296a774d1b

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=deaa1883ddb87579c3e1812a33c94dd69eab60c5

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 8 subtests

Status Summary

Firefox

OK : 2
FAIL : 17

Chrome

OK : 1
PASS : 7
FAIL : 2
ERROR: 1

Safari

OK : 2
FAIL : 17

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /editing/edit-context/edit-context-basics.tentative.html [wpt.fyi]
  • Testing EditContext Dictionary Init: FAIL (Chrome: PASS, Safari: FAIL)
  • A contenteditable element should remain editable after attaching and detaching EditContext.: FAIL (Chrome: PASS, Safari: FAIL)
  • EditContext can be associated with an element that is not in the tree.: FAIL (Chrome: PASS, Safari: FAIL)
  • If an element is removed from the tree, the associated EditContext remains connected to the element.: FAIL (Chrome: PASS, Safari: FAIL)
  • If an element's ancestor is removed from tree, the associated EditContext remains connected to the element.: FAIL (Chrome: PASS, Safari: FAIL)
  • .attachedElements() should return associated element: FAIL (Chrome: PASS, Safari: FAIL)
  • Testing EditContext update text, selection and layout: FAIL (Chrome: FAIL, Safari: FAIL)
  • updateCharacterBounds(), characterBounds(), and characterBoundsRangeStart should work properly: FAIL (Chrome: PASS, Safari: FAIL)
  • EditContext should allow a backwards selection: FAIL (Chrome: FAIL, Safari: FAIL)
• /editing/edit-context/edit-context-input.tentative.html [wpt.fyi]
  • Testing EditContext English typing: FAIL (Safari: FAIL)
  • Text insertion with non-collapsed selection: FAIL (Safari: FAIL)
  • EditContext should disable DOM mutation: FAIL (Safari: FAIL)
  • beforeInput(insertText) should be cancelable: FAIL (Safari: FAIL)
  • EditContext should not receive events after being detached from element: FAIL (Safari: FAIL)
  • Backspace and delete in EditContext: FAIL (Safari: FAIL)
  • Backspace and delete with existing selection: FAIL (Safari: FAIL)
  • EditContext constructed outside iframe can be used in iframe: FAIL (Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0df9c9f3db2
[wpt PR 44182] - [EditContext] Allow backwards selection, a=testonly
https://hg.mozilla.org/integration/autoland/rev/f6f762ca3bbb
[wpt PR 44182] - Update wpt metadata, a=testonly

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/b0df9c9f3db2
https://hg.mozilla.org/mozilla-central/rev/f6f762ca3bbb