1876459 - [wpt-sync] Sync PR 44187 - Split requests/errors handlings in sw.js to a sub script

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44187 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44187
Details from upstream follow.

sisidovski <[e-mail]> wrote:

Split requests/errors handlings in sw.js to a sub script

We'd like to add the test case when there is no fetch handler in SW.
But we'd like to use the same mechanism to monitor errors. So this CL
moves some code into a sub script, and that will be imported from
another service worker file in the next CL.

Change-Id: Ie7663ef3a7c7e614d063abc521e4a4d1f9f791a5
Bug: 1519727, 1511459

Reviewed-on: https://chromium-review.googlesource.com/5232748
WPT-Export-Revision: 046a9e69f38a073d541923482c6923a4cfce3936

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 44187 applied with additional changes from upstream: e7b773cb7892b3db5190e94cb0945d84bf88a5f4

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a77964af1db3f125f8336056958885a88b36f0f

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 14 subtests

Status Summary

Firefox

OK : 2
FAIL: 21

Chrome

OK : 2
PASS: 5
FAIL: 16

Safari

OK : 2
FAIL: 21

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /service-workers/service-worker/tentative/static-router/static-router-main-resource.https.html [wpt.fyi]
  • Main resource load matched with the condition: FAIL (Chrome: FAIL, Safari: FAIL)
  • Main resource load matched with the ignore case condition: FAIL (Chrome: FAIL, Safari: FAIL)
  • Main resource load matched without the ignore case condition: FAIL (Chrome: PASS, Safari: FAIL)
  • Main resource load not matched with the condition: FAIL (Chrome: PASS, Safari: FAIL)
  • Main reosurce load matched with the service worker having multiple rules: FAIL (Chrome: FAIL, Safari: FAIL)
  • Main resource load matched with the cache source: FAIL (Chrome: FAIL, Safari: FAIL)
  • Main resource fallback to the network when there is no cache entry: FAIL (Chrome: FAIL, Safari: FAIL)
• /service-workers/service-worker/tentative/static-router/static-router-subresource.https.html [wpt.fyi]
  • Subresource load not matched with URLPattern condition: FAIL (Chrome: PASS, Safari: FAIL)
  • Subresource load matched with URLPattern condition: FAIL (Chrome: FAIL, Safari: FAIL)
  • Subresource cross origin load matched with URLPattern condition via constructed object: FAIL (Chrome: FAIL, Safari: FAIL)
  • Subresource load matched with ignoreCase URLPattern condition: FAIL (Chrome: FAIL, Safari: FAIL)
  • Subresource load matched without ignoreCase URLPattern condition: FAIL (Chrome: PASS, Safari: FAIL)
  • Subresource load matched with URLPattern condition via URLPatternInit: FAIL (Chrome: FAIL, Safari: FAIL)
  • Subresource cross origin load not matched with URLPattern condition via URLPatternInit: FAIL (Chrome: FAIL, Safari: FAIL)
  • Subresource load matched with URLPattern condition via string: FAIL (Chrome: FAIL, Safari: FAIL)
  • Subresource cross origin load not matched with URLPattern condition via string: FAIL (Chrome: FAIL, Safari: FAIL)
  • Subresource load matched with RequestMode condition: FAIL (Chrome: FAIL, Safari: FAIL)
  • Subresource load matched with the nested or condition: FAIL (Chrome: FAIL, Safari: FAIL)
  • Subresource load matched with the next or condition: FAIL (Chrome: FAIL, Safari: FAIL)
  • Subresource load not matched with or condition: FAIL (Chrome: PASS, Safari: FAIL)
  • Subresource load matched with the cache source rule: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87665bd2f363
[wpt PR 44187] - Split requests/errors handlings in sw.js to a sub script, a=testonly

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/87665bd2f363