1876461 - [wpt-sync] Sync PR 44188 - Raise if the fetch-event source is used without a fetch handler.

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44188 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44188
Details from upstream follow.

Yoshisato Yanagisawa <[e-mail]> wrote:

Raise if the fetch-event source is used without a fetch handler.

This is CL implements:
https://github.com/yoshisatoyanagisawa/ServiceWorker/pull/2

Upon the PR, TypeError is thrown if the fetch-event source is used
without having a fetch handler in the service worker script.

Bug: 1511459
Change-Id: I0197ab55a223b03c8e6ca8e46e9a16d461d9bc9c
Reviewed-on: https://chromium-review.googlesource.com/5233688
WPT-Export-Revision: ab713be3b3e1ee994ed5ffcbfc98a97ffb708933

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 44188 applied with additional changes from upstream: 89cff6a99291719842e719c82d1968a8b64aa28e, e7b773cb7892b3db5190e94cb0945d84bf88a5f4

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 44188 applied with additional changes from upstream: e7b773cb7892b3db5190e94cb0945d84bf88a5f4, 46c16b1a5ef923ddc62fb7c93bbfd5d9212f5627

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=25425cceb19b62284cb887701559c9cfa8b0e8ee

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 2 subtests

Status Summary

Firefox

OK : 2
FAIL : 3

Chrome

OK : 1
PASS : 1
FAIL : 1
TIMEOUT: 2

Safari

OK : 2
FAIL : 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /service-workers/service-worker/tentative/static-router/static-router-invalid-rules.https.html [wpt.fyi]
  • addRoutes should raise for invalid request method.: FAIL (Chrome: TIMEOUT, Safari: FAIL)
• /service-workers/service-worker/tentative/static-router/static-router-no-fetch-handler.https.html [wpt.fyi]
  • The router rule is evaluated without fetch handlers in service worker: FAIL (Chrome: FAIL, Safari: FAIL)
  • addRoutes should raise if the fetch-event source is used without onfetch: FAIL (Chrome: PASS, Safari: FAIL)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0fe35075279f
[wpt PR 44188] - Raise if the fetch-event source is used without a fetch handler., a=testonly
https://hg.mozilla.org/integration/autoland/rev/62c458e6a30a
[wpt PR 44188] - Update wpt metadata, a=testonly

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/0fe35075279f
https://hg.mozilla.org/mozilla-central/rev/62c458e6a30a