1876463 - [wpt-sync] Sync PR 44189 - Move main resource test functions into helper js

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44189 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44189
Details from upstream follow.

sisidovski <[e-mail]> wrote:

Move main resource test functions into helper js

This CL moves some of functions in the main resource test file to the
helper js file in order to make them reusable from other tests.

Bug: 1519727, 1511459
Change-Id: Idaede86258009d109bfcb72af734b2611357485c
Reviewed-on: https://chromium-review.googlesource.com/5232708
WPT-Export-Revision: 1ad3f9e7f81016226b5e3a42c536a5ba2dc5c6e6

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 44189 applied with additional changes from upstream: 89cff6a99291719842e719c82d1968a8b64aa28e, e7b773cb7892b3db5190e94cb0945d84bf88a5f4

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=64ca9c57bbd0f09791ca97dcecccdf15f484e971

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=398b04a7d938c6200eae7e5a73240a4bba6bca31

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 7 subtests

Status Summary

Firefox

OK : 2
FAIL: 8

Chrome

OK : 2
PASS: 3
FAIL: 5

Safari

OK : 2
FAIL: 8

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /service-workers/service-worker/tentative/static-router/static-router-invalid-rules.https.html [wpt.fyi]
  • addRoutes should raise for invalid request method.: FAIL (Chrome: PASS, Safari: FAIL)
• /service-workers/service-worker/tentative/static-router/static-router-main-resource.https.html [wpt.fyi]
  • Main resource load matched with the condition: FAIL (Chrome: FAIL, Safari: FAIL)
  • Main resource load matched with the ignore case condition: FAIL (Chrome: FAIL, Safari: FAIL)
  • Main resource load matched without the ignore case condition: FAIL (Chrome: PASS, Safari: FAIL)
  • Main resource load not matched with the condition: FAIL (Chrome: PASS, Safari: FAIL)
  • Main reosurce load matched with the service worker having multiple rules: FAIL (Chrome: FAIL, Safari: FAIL)
  • Main resource load matched with the cache source: FAIL (Chrome: FAIL, Safari: FAIL)
  • Main resource fallback to the network when there is no cache entry: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/575a58b90c0d
[wpt PR 44189] - Move main resource test functions into helper js, a=testonly

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/575a58b90c0d