1876496 - nsIDOMWindowUtils.getUnanimatedComputedStyle throws NS_ERROR_FAILURE when called with custom property

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Nicolas Chevobbe [:nchevobbe]]

The following expression throws

DOMWindowUtils.getUnanimatedComputedStyle(
  document.body,
  null,
  "--custom",
  DOMWindowUtils.FLUSH_NONE
)

(can be triggered by going to https://ffx-devtools-at-property.glitch.me/ , opening the animation panel and selecting a div)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Zach, is this something similar to Bug 1875441 ?

Comment 2

[Zach Hoffman [:zrhoffman]]

Oops, the custom property in nsDOMWindowUtils::GetUnanimatedComputedStyle should have the -- prefix removed, similar to <https://searchfox.org/mozilla-central/rev/cee2c396081d950f9e3401113fb179999e404ab8/dom/animation/KeyframeUtils.cpp#577-578>. Patch incoming...

Comment 3

[Zach Hoffman [:zrhoffman]]

Attachment: Bug 1876496 - Remove prefix from custom property name passed to AnimatedPropertyID r=nchevobbe,emilio,#animation

Including the -- prefix in custom property names caused
Servo_ComputedValues_ExtractAnimationValue to not find custom properties
that nsDOMWindowUtils::GetUnanimatedComputedStyle passed.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2af2984af50a
Remove prefix from custom property name passed to AnimatedPropertyID r=nchevobbe,emilio

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1846516

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2af2984af50a

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:zrhoffman, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox123 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Zach Hoffman [:zrhoffman]]

Nicolas, would this be useful to uplift or no?

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Zach Hoffman [:zrhoffman] from comment #8)

Nicolas, would this be useful to uplift or no?

No it's fine I think, animating custom properties is tied to layout.css.properties-and-values.enabled, which is still Nightly only