1876519 - Make martinlaxenaire.github.io/gpu-curtains work with WebGPU

Status: NEW

(Core :: Graphics: WebGPU, task, P3)

Description

[Nicolas Silva [:nical]]

https://martinlaxenaire.github.io/gpu-curtains/

I see a lot flood of external image related errors in the logs.

Comment 1

[Erich Gubler [:ErichDonGubler] (he/him)]

Those errors, which I see as:

Uncaught Error: GPUDeviceManager: could not upload texture: planeTexture because: GPUQueue.copyExternalImageToTexture: 'source' member of GPUImageCopyExternalImage could not be converted to any of: ImageBitmap, HTMLCanvasElement, OffscreenCanvas.

…are thrown when the page attempts to use a video element. This is at least blocked on VideoFrame, likely webgpu-external-textures as a whole.

Comment 2

[Mayank Bansal]

Also spends tons of time in compiling shaders: https://share.firefox.dev/3W7c4m9
Edit: Filed bug 1939985

Comment 3

[Mayank Bansal]

Attachment: Demo examples and their errors.txt

These are the specific demos that do not work in Nightly from https://martinlaxenaire.github.io/gpu-curtains/examples/ :

https://martinlaxenaire.github.io/gpu-curtains/examples/gltf-loader-ibl-shading/
https://martinlaxenaire.github.io/gpu-curtains/examples/gltf-dom-meshes/
https://martinlaxenaire.github.io/gpu-curtains/examples/camera-renderer-transforms-bloom-pass/
https://martinlaxenaire.github.io/gpu-curtains/examples/shadow-mapping/

The attached file contains the errors while running each of these. Let me know if I should create separate bug for each of these demos.

Comment 4

[Andy Leiserson [:aleiserson]]

Filed https://github.com/gfx-rs/wgpu/issues/7356.

Comment 5

[Andy Leiserson [:aleiserson]]

Testing a local build with my fix for #7356:

shadow-mapping works.

camera-renderer-transforms-bloom-pass fails with the following error:

Shader [...] parsing error: the type of `result` is expected to be `vec4<f32>`, but got `vec4<i32>`
   ┌─ wgsl:36:11
   │
36 │       var result: vec4f = mix(vec4(0), color, step(params.threshold, brightness));
   │           ^^^^^^ definition of `result`

This problem should be resolved by Jim's function database, expected soon. I have passed this to Jim as a test case for that.

gltf-dom-meshes fails with:

Uncaptured WebGPU error: Texture with 'BoomBox_Mat: baseColorTexture' label has been destroyed
Uncaptured WebGPU error: Texture with 'BoomBox_Mat: normalTexture' label has been destroyed

gltf-loader-ibl-shading fails with:

Uncaught DOMException: GPUCanvasContext.getCurrentTexture: Canvas not configured