1876612 - Button baseline doesn't propagate to grid baseline with align-items: baseline

Status: RESOLVED FIXED

(Core :: Layout: Grid, defect, P2)

Description

[caleb]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.2.1 Safari/605.1.15

Steps to reproduce:

TLDR: https://jsfiddle.net/haf52ozd/

1. Have a button inside a grid with align-items: baseline
2. Try to align that grid to another baseline, e.g. as an inline-grid, or as a flex item in a flex container with align-items: baseline

Actual results:

The baselines do not align

Expected results:

The baselines should align. They align correctly with the default align-items: stretch.

This stopped working around Firefox 122. It worked in Firefox 121 and earlier.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Layout: Grid' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=59f5c1b05b863d8524c97a20e49132a5eca2753a&tochange=99e226ce1286214f8abc62d473577a491ea42fb0

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:tlouw, since you are the author of the regressor, bug 1609403, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Tiaan Louw]

Attachment: bug-1876612.html

Comment 5

[Tiaan Louw]

Attachment: Bug 1876612 - Use the newer function for calculating item baselines r=#layout

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b48848c32dbe
Use the newer function for calculating item baselines r=layout-reviewers,emilio

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b48848c32dbe

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:tlouw, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox123 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Daniel Holbert [:dholbert]]

er, I missed that this was a regression when setting status flags to wontfix.

It might be worth uplifting this to beta123, given that it's relatively targeted and we're still in the first half of the beta period (Firefox 123 ships on Feb 20th). What do you think, Tiaan?

Comment 10

[Tiaan Louw]

Comment on attachment 9376938 [details]
Bug 1876612 - Use the newer function for calculating item baselines r=#layout

Beta/Release Uplift Approval Request

• User impact if declined: This bug causes a visual issue where items inside buttons are not correctly aligned according to how users expect.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This was a small fix and covered by WPT tests and should be very low risk.
• String changes made/needed:
• Is Android affected?: Yes

Comment 11

[Pascal Chevrel:pascalc]

Comment on attachment 9376938 [details]
Bug 1876612 - Use the newer function for calculating item baselines r=#layout

Approved for 123 beta 6, thanks.

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/3898d1885404

Comment 13

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/3898d1885404