1876699 - Clean up macOS system font code a bit.

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

See bug 1875384 for the reasoning.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1876699 - Clean-up some macOS system font code. r=jfkthame

No behavior change, just drive-by.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1876699 - Make message-box font size match menu and other regular-size fonts. r=jfkthame

See bug 1875384 for reasoning.

Depends on D199703

Comment 3

[Dão Gottwald [:dao]]

Wouldn't this change the font size in the main browser window, e.g. the tab strip and toolbars?

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Hmm, yes it does, I wonder why we use message-box there tho? It's not a dialog... But I guess there aren't all that many better choices...

Comment 5

[Jules Simplicio [:jules]]

Looks like tabs in macOS (e.g. Safari, Finder) tend to use the 11px/message-box font sizing, so it's about the same pattern.

Comment 6

[Dão Gottwald [:dao]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)

Hmm, yes it does, I wonder why we use message-box there tho? It's not a dialog... But I guess there aren't all that many better choices...

It's weirdly named, but nevertheless has been used as the default font for all kinds of windows since forever.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09a1abcfcfb7
Clean-up some macOS system font code. r=jfkthame

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/09a1abcfcfb7