1876806 - Downloaded files in private tabs get deleted after deleting browsing data

Status: VERIFIED FIXED

(Firefox for Android :: Downloads, defect)

Description

[Rilele]

Steps to reproduce:

1. Open a private tab
2. Go to https://www.mozilla.org
3. Long tab on a picture and select "Save image"
4. Open the settings
5. Tab on "Delete browsing data"
6. Ensure all checkboxes are checked, then tab on "Delete browsing data"

Actual results:

The picture from 3. is not in the downloads folder. It gets created at 3. but gets deleted at step 6.

Expected results:

The picture from 3. should be in the downloads folder.

Comment 1

[Rilele]

I'm using Firefox Nightly 124.0a1 (Build # 2015999783) on Android 14 on a Google Pixel 6a.
The bug does happen with all downloaded files, not just images.

Comment 2

[Donal Meehan [:dmeehan]]

Going to look at reverting the regressor in 122 and getting a fix in time for 123

Comment 3

[Donal Meehan [:dmeehan]]

Setting 122 as Fixed, the regressor was backed out of the 122 branch.
Fenix/Focus 122.1.0 will ship with this bug fixed.
A follow-up fix will need to land in time for Fx123, or we should also consider reverting there before building 123.0 RC.

Comment 4

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1876806 - Do not remove downloaded files in private tabs after deleting browsing data (#5461)

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug has a release status flag that shows some version of Firefox is affected, thus it will be considered confirmed.

Comment 6

[BMO Github Automation]

Authored by https://github.com/Amejia481
https://github.com/mozilla-mobile/firefox-android/commit/a1f24fffc970a95be76c2e06ed75061989b6f417
[main] Bug 1876806 - Do not remove downloaded files in private tabs after deleting browsing data

Comment 7

[Pascal Chevrel:pascalc]

Please request uplift on the fix once you have it verified by QA, thanks!

Comment 8

[Arturo Mejia [:amejia]]

Hi Rilele, would you mind verifying if the issue is addressed on Firefox for Android Nightly

Thank you in advance!

Comment 9

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1876806 - Do not remove downloaded files in private tabs after deleting browsing data (backport #5461) (#5525)

Comment 10

[Arturo Mejia [:amejia]]

Comment on attachment 9379013 [details] [review]
[mozilla-mobile/firefox-android] Bug 1876806 - Do not remove downloaded files in private tabs after deleting browsing data (backport #5461) (#5525)

Beta/Release Uplift Approval Request

• User impact if declined: Files downloaded on private mode, will be deleted when users click "deleting browsing data"
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We are just preventing files to get deleted, when users click "deleting browsing data" on private mode.
• String changes made/needed:
• Is Android affected?: Yes

Comment 11

[Rilele]

I can't reproduce the bug anymore, so it seems fixed. (with 124.0a1 (Build #2016002087))

Comment 12

[Arturo Mejia [:amejia]]

Thank you so much, for verifying!

Comment 13

[Pascal Chevrel:pascalc]

Comment on attachment 9379013 [details] [review]
[mozilla-mobile/firefox-android] Bug 1876806 - Do not remove downloaded files in private tabs after deleting browsing data (backport #5461) (#5525)

Approved for 123 beta 9, thanks.

Comment 14

[BMO Github Automation]

Authored by https://github.com/mergify[bot]
https://github.com/mozilla-mobile/firefox-android/commit/1d945e0a3743cb8b8c456396a7320094113b9182
[releases_v123] Bug 1876806 - Do not remove downloaded files in private tabs after deleting browsing data (backport #5461) (#5525)

Comment 15

[Lorand Janos]

Verified on the latest Nightly 124.0a1 (from 2024-02-12) and on the latest Beta 123.0b9 builds.
The downloaded files are kept in the downloads folder after downloading it in private browsing and deleting browsing data.
Device used: Samsung Galaxy S23 Ultra (Android 14).
Marking the ticket as verified.