1876962 - Firefox doesn't redraw blocks after changing :has(:target) state

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Siemens]

Attachment: has-target-bug.html

Steps to reproduce:

1. Open has-target-bug.html
2. Click on links t1, t2, t3 in any order any number of times

Actual results:

Firefox doesn't redraw blocks after losing, and sometimes after getting :has(:target) on a block.
So there could be multiple blocks that are rendered as "targeted!" while this can't be true because they're siblings.
Sometimes after the page refresh all three elements shows "targeted!".

I've added :hover to make the issue clear. After forced redrawing caused by hovering over, all blocks are rendered correctly, and only the proper one shows " targeted".

Expected results:

After clicking "t1", the text content should look like this:
t1 targeted!
t2
t3

After clicking "t2", the text content should look like this:
t1
t2 targeted!
t3

After clicking "t3", the text content should be:
t1
t2
t3 targeted!

After refreshing the page, the text context should correspond to the anchor in the address bar.

It works in Chromium 107.0.5304.88 as expected.

Comment 1

[David Shin[:dshin]]

Attachment: Bug 1876962: Part 1 - Factor out transfer of RelativeSelectorMatchingState to ComputedValueFlags. r=#style

Comment 2

[David Shin[:dshin]]

Attachment: Bug 1876962: Part 2 - Take eager pseudo-element rules into account in style sharing. r=#style

Depends on D200190

Comment 3

[David Shin[:dshin]]

Attachment: Bug 1876962: Part 3 - Take lazy pseudo-element rules into account in cahcing. r=#style

Depends on D200191

Comment 4

[David Shin[:dshin]]

Attachment: Bug 1876962: Part 1 - Fix up logic for determining `Rightmost` in `matches_selector`. r=#style

Would generate invalid results :has() selector if it's in the subject
compound but also uses a pseudo-selector (e.g. .foo:has(.bar)::after).

Comment 5

[David Shin[:dshin]]

Attachment: Bug 1876962: Part 2 - Add `:has` to revalidation selector. r=#style

Depends on D200222

Comment 6

[David Shin[:dshin]]

Attachment: Bug 1876962: Part 3 - Remove special case handling for `:has` in style sharing. r=#style

Was added in bug 1793012. No longer needed since :has is part of
reinvalidation selectors now. The new approach can be potentially-
pricey, but is a lot simpler.

Depends on D200223

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0d1a0931b11
Part 1 - Fix up logic for determining `Rightmost` in `matches_selector`. r=firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/9032a37ea009
Part 2 - Add `:has` to revalidation selector. r=firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/a30b42d227dd
Part 3 - Remove special case handling for `:has` in style sharing. r=firefox-style-system-reviewers,emilio

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44539 for changes under testing/web-platform/tests

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e0d1a0931b11
https://hg.mozilla.org/mozilla-central/rev/9032a37ea009
https://hg.mozilla.org/mozilla-central/rev/a30b42d227dd

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 12

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-02-10 Nightly build on macOS 12.
Verified as fixed on Firefox 124.0b2 and Firefox Nightly 125.0a1 on macOS 12, Windows 10, Ubuntu 22.