Declarative Shadow DOM: this.attachInternals().shadowRoot is always null
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox124 | --- | fixed |
People
(Reporter: constantin.schellhammer, Assigned: avandolder)
Details
Attachments
(2 files)
Steps to reproduce:
- add declarative shadow dom custom element with template.shadowrootmode = "closed" or "open"
- register custom element: constructor:
this.attachInternals().shadowRoot
Actual results:
this.attachInternals().shadowRoot is null
Expected results:
this.attachInternals().shadowRoot should not be null for both "open" and "closed" shadow roots (Chrome/Edge behave as expected). For "closed" shadow roots this.shadowRoot is null, too. So this.attachInternals().shadowRoot is the only way to make a "closed" shadow root interactive.
|
||
Comment 1•5 months ago
|
||
The Bugbug bot thinks this bug should belong to the 'Core::DOM: Core & HTML' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
|
||
Comment 2•5 months ago
|
||
We might not be setting the available to element internals to true (https://html.spec.whatwg.org/#parsing-main-inhead:available-to-element-internals)?
|
|
||
Comment 3•5 months ago
|
||
|
|
||
Comment 4•5 months ago
|
||
Reporter: thanks for reporting, it would also really help if you attach a testcase instead of describing the problem in prose.
|
|
||
Updated•5 months ago
|
|
Reporter | |
Comment 5•5 months ago
|
||
testcase:
<!DOCTYPE html>
<html lang="en">
<head>
<title>Bug 1877025</title>
<script type="module">
customElements.define("custom-element",class extends HTMLElement {
#internals;
constructor() {
super();
this.#internals = this.attachInternals();
console.assert(this.#internals.shadowRoot!==null);
}
})
</script>
</head>
<body>
<custom-element>
<template shadowrootmode="closed">
Bug 1877025
</template>
</custom-element>
</body>
</html>
|
Assignee | |
Comment 6•5 months ago
|
||
(In reply to Peter Van der Beken [:peterv] from comment #2)
We might not be setting the available to element internals to true (https://html.spec.whatwg.org/#parsing-main-inhead:available-to-element-internals)?
Ah, since we create the shadow root from the parser, I don't think the element would have a CustomElementData yet, which we check before setting available to element internals.
|
|
Assignee | |
Comment 7•5 months ago
|
||
|
||
Updated•5 months ago
|
|
||
Comment 8•5 months ago
|
||
Do we need this on beta?
Pushed by avandolder@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b34477dd4ac2 Make declarative shadow roots of custom elements available to element internals. r=peterv,dom-core
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44419 for changes under testing/web-platform/tests
|
||
Comment 11•5 months ago
|
||
Backed out for lint failure on shadow-dom/declarative/declarative-shadow-dom-available-to-element-internals.html
Backout link: https://hg.mozilla.org/integration/autoland/rev/6ac6ad4ee06483569b7ac1e6789796a51414f802
Log link: https://treeherder.mozilla.org/logviewer?job_id=446171810&repo=autoland&lineNumber=69
Upstream PR was closed without merging
|
||
Comment 13•5 months ago
|
||
Pushed by avandolder@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/40bac1b10006 Make declarative shadow roots of custom elements available to element internals. r=peterv,dom-core
|
||
Comment 14•4 months ago
|
||
| bugherder | ||
Upstream PR merged by moz-wptsync-bot
|
|
Assignee | |
Updated•4 months ago
|
Description
•