1877090 - Text in the selected row is barely visible

Status: VERIFIED FIXED

(DevTools :: Storage Inspector, defect)

Description

[6k64x4ma]

Attachment: screenshot.webp

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:123.0) Gecko/20100101 Firefox/123.0

Steps to reproduce:

1. Load any page.
2. Open the Storage Inspector.
3. Select any row in the table widget.

Actual results:

• The text in the selected row is barely visible.

Expected results:

• The text should be white.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2535b5e00abc662e478601037a00e314799243a2&tochange=0cf1d9d7091d52e5014d6e91573c0ff7549f9cc3

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:mossop, since you are the author of the regressor, bug 1857999, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Dave Townsend [:mossop]]

This appears to be another problem with the ordering of the stylesheets. The rules for injecting the theme stylesheet are to put it immediately after the global stylesheet and this is what is happening. But the rule that sets a selected cell's color is being overridden by a later stylesheet's rule. Prior to bug 1857999 the theme stylesheet was being injected last so always took precedence.

I'm not sure what the best way to fix this is. We could make the theme rule a little more specific or if widgets.css is a sort of global stylesheet maybe we should extend the logic to putting the theme sheet after that. What do you think Alex?

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1877090 - [devtools] Fix selected row color on the storage panel.

This rule overrides the expected color set by light/dark-theme.css.

Comment 4

[Alexandre Poirot [:ochameau]]

It looks like we can simplify by removing widgets.css's color?
This TableWidget thing is only used by the Storage Panel.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1857999

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06f49882403c
[devtools] Fix selected row color on the storage panel. r=devtools-reviewers,nchevobbe

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/06f49882403c

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:ochameau, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox123 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Alexandre Poirot [:ochameau]]

Comment on attachment 9379983 [details]
Bug 1877090 - [devtools] Fix selected row color on the storage panel.

Beta/Release Uplift Approval Request

• User impact if declined: Content of the storage panel is hard to read when the lines/rows are selected
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only a css rule being removed.
• String changes made/needed:
• Is Android affected?: No

Comment 10

[Simona Badau, Desktop QA]

Reproduced the initial issue on Firefox 123 on Windows 10 x64.

Verified as fixed using Firefox 124.0b2 - the text in the selected row is now visible and white. Tested on Windows 10 x64, Ubuntu 22.04 x64 and macOS 13.

Comment 11

[Pascal Chevrel:pascalc]

Comment on attachment 9379983 [details]
Bug 1877090 - [devtools] Fix selected row color on the storage panel.

Low risk, approved for our planned dot release next week, thanks.

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/e140c63c3f22

Comment 13

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-release/rev/e140c63c3f22

Comment 14

[Simona Badau, Desktop QA]

Verified as fixed using Firefox 123.0.1 on macOS 13, Ubuntu 22.04 and Windows 10 x64.