1877096 - [wdspec] Traverse history tests can fail when the URL hasn't been updated yet

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As of now the BiDi spec is a bit vague and implementations do not wait until the navigation to the page in browser history has actually started, but only until the history index has been set. As such the currently existing tests can fail especially for slow running builds where the URL hasn't been updated yet.

As such we should not run a single assertion only but use the Poll feature to wait until the URL is actually set.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1877096 - [wdspec] Fix AsyncPoll.until() to correctly await the result of the condition.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1877096 - [wdspec] Improve tests for browsingContext.traverseHistory to wait for the expected URL.

Until the command isn't completely specified and implemented
it doesn't await for the navigation to be completed. As such
the tests will have to temporarily await for it.

Depends on D199887

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2762ac7ae9c
[wdspec] Fix AsyncPoll.until() to correctly await the result of the condition. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/5e806fd0138f
[wdspec] Improve tests for browsingContext.traverseHistory to wait for the expected URL. r=webdriver-reviewers,jdescottes

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44286 for changes under testing/web-platform/tests

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f2762ac7ae9c
https://hg.mozilla.org/mozilla-central/rev/5e806fd0138f

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 9376984 [details]
Bug 1877096 - [wdspec] Fix AsyncPoll.until() to correctly await the result of the condition.

Beta/Release Uplift Approval Request

• User impact if declined: None, test-only changes
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No risk, the test now awaits for the URL to have changed.
• String changes made/needed:
• Is Android affected?: Yes

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9376984 [details]
Bug 1877096 - [wdspec] Fix AsyncPoll.until() to correctly await the result of the condition.

Approved for 123 beta 8, thanks.

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/7c22e3bc3b02
https://hg.mozilla.org/releases/mozilla-beta/rev/312508bbb53c

Comment 10

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/7c22e3bc3b02
https://hg.mozilla.org/releases/mozilla-beta/rev/312508bbb53c