1877123 - [L10N] The counter from tabs tray is not translated in Arabic

Status: VERIFIED FIXED

(Fenix :: Tabs, defect, P2)

Description

[Mira Lobontiu (Android QA)]

Attachment: bug.png

Steps to reproduce

1. Open at least one tab.
2. Go to Settings - Languages, and set fenix in Arabic.
3. Exit Settings, and tap on the tab counter from the toolbar.
4. Observe the tabs counter from the tabs tray.

Expected behavior

The number of opened tabs is translated also in Arabic, as it is translated in the page's counter.

Actual behavior

The number of opened tabs is not translated in Arabic.

Device information

• Firefox version: Beta 123.0b3, Nightly 124.0a1 from 1/29
• Android device: Oppo Find X3 Lite (Android 11)

Any additional information?

• NOT reproducible on Fenix 122.0 build 2

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Fenix::Tabs' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Delphine Lebédel [:delphine - Use needinfo]]

This looks like a regression since this is not reproducible on Fenix v122.
Also I don't think this is an l10n bug as those numbers don't come from localizers. It seems more like an engineering issue that the mobile team should investigate.

Comment 3

[Mira Lobontiu (Android QA)]

Last good build: 12th of July, 2023
First bad build: 13th of July, 2023

Comment 4

[Joe M [:jmahon]]

:noah, could you take a look at the above range of changes and see if there's a regressor in there?

Comment 5

[Noah Bond [:007]]

The dates in question are when the Tabs Tray to Compose rewrite was initially enabled in Nightly. This bug will only be present when the feature is enabled though, so by default in Nightly and Beta.

This is simply an issue with how the numbers are being converted to strings; they aren't using the proper formatting function to translate them. This is an easy fix though and I can have a patch out for review this week. I'll also try to investigate if there are other instances of this.

Comment 6

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1877123 - Fix number localization in `TabCounter` and `TabTools` (#5430)

Comment 7

[Bob Hood [:bhood]]

Noah, do you think this is important enough to uplift into Fx123 prior to release?

Comment 8

[Noah Bond [:007]]

No, this bug only affects a rewrite that is enabled in Nightly and Beta. This can ride the trains

Comment 9

[BMO Github Automation]

Authored by https://github.com/MozillaNoah
https://github.com/mozilla-mobile/firefox-android/commit/d03309c94457e9dc692499b765ba0e6b285ce295
[main] Bug 1877123 - Fix number localization in TabCounter and TabTools

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:007, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox123 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Adina Petridean QA [:apetridean]]

Attachment: arabic.JPEG

Comment 12

[Adina Petridean QA [:apetridean]]

Verified as fixed on Nightly 124.0a1 from 02/07 with Motorola G9 plus (Android 11) and OnePlus A3000 (Android 6).