1877162 - WebGPU demo (https://karl-pickett.dev/galaxy/index.html) doesnt draw anything on Nightly

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect, P3)

Description

[Mayank Bansal]

Go to https://karl-pickett.dev/galaxy/index.html

AR: Nothing is drawn on the screen. Chrome displays things.

18:14:32.907 internal rendering resolution is 1792 x 640 main.js:150:13
18:14:32.921

Shader 'rough_module' parsing error: expected assignment or increment/decrement, found 'GRAVITY'
┌─ wgsl:217:11
│
217 │ const GRAVITY = -0.04;
│ ^^^^^^^ expected assignment or increment/decrement

18:14:32.921
Encountered one or more errors while creating shader module "bin_module"
18:14:32.921
WebGPU compilation info for shader module "bin_module" (1 error(s), 0 warning(s), 0 info)
18:14:32.921

Shader validation error:
┌─ bin_module:89:1
│
89 │ ╭ fn get_texture_linear_index(view_x: f32, view_y: f32) -> i32
90 │ │ {
91 │ │ return i32(floor(view_x) + floor(view_y) * SCREEN_WIDTH_PX);
│ │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ naga::Expression [6]
│ ╰────────────────────────────────────────────────────────────────^ naga::Function [1]

18:14:32.921
Encountered one or more errors while creating shader module "fine_module"
18:14:32.921
WebGPU compilation info for shader module "fine_module" (1 error(s), 0 warning(s), 0 info)
18:14:32.921

Shader validation error:
┌─ fine_module:89:1
│
89 │ ╭ fn get_texture_linear_index(view_x: f32, view_y: f32) -> i32
90 │ │ {
91 │ │ return i32(floor(view_x) + floor(view_y) * SCREEN_WIDTH_PX);
│ │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ naga::Expression [6]
│ ╰────────────────────────────────────────────────────────────────^ naga::Function [1]

18:14:32.921
Encountered one or more errors while creating shader module "quad_fragment_module"
18:14:32.921
WebGPU compilation info for shader module "quad_fragment_module" (1 error(s), 0 warning(s), 0 info)
18:14:32.921 Error matching shader requirements against the pipeline, caused by: Shader module is invalid
18:14:32.921 Error matching ShaderStages(VERTEX) shader requirements against the pipeline, caused by: Shader module is invalid
18:14:32.926 Pipeline is invalid
18:14:32.926 Bind group layout is invalid
18:14:32.928 In a set_pipeline command, caused by: Compute pipeline Id(0,1,d3d12) is invalid
18:14:32.928 Command encoder is invalid
18:14:32.928 In a set_pipeline command, caused by: Render pipeline Id(0,1,d3d12) is invalid

Comment 1

[Mayank Bansal]

Attachment: about:support

Comment 2

[Erich Gubler [:ErichDonGubler] (he/him)]

Blocked by at least bug 1878320.

Comment 3

[Bob Hood [:bhood]]

WebGPU is unreleased tech. Dropping Severity to S3 to remove from org tracking.

Comment 4

[Mayank Bansal]

Profile with webgpu preset logging: https://share.firefox.dev/4f67NpG

Error in webconsole:
12:43:37.745 devicePixelRatio is 1.5 main.js:145:13
12:43:37.745 internal rendering resolution: 1792 x 640 main.js:146:13
12:43:37.745 canvas css px: 1374 x 491 main.js:147:13
12:43:37.745 canvas real px: 2061 x 736.5 main.js:148:13
12:43:37.746 MISC_BUFFER_SIZE: 1665536 main.js:211:13
12:43:37.758 Uncaptured WebGPU error: Shader module creation failed: Shader validation error
12:43:37.758
Encountered one or more errors while creating shader module "rough_module"
12:43:37.758
WebGPU compilation info for shader module "rough_module" (1 error(s), 0 warning(s), 0 info)
12:43:37.758

Shader validation error: Function [0] 'get_texture_linear_index' is invalid
┌─ rough_module:89:1
│
89 │ ╭ fn get_texture_linear_index(view_x: f32, view_y: f32) -> i32
90 │ │ {
91 │ │ return i32(floor(view_x) + floor(view_y) * SCREEN_WIDTH_PX);
│ │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ naga::Expression [5]
│ ╰────────────────────────────────────────────────────────────────^ naga::Function [0]
│
= Expression [5] is invalid
= Operation Multiply can't work with [3] (of type Scalar(Scalar { kind: Float, width: 4 })) and [4] (of type Scalar(Scalar { kind: Sint, width: 4 }))

12:43:37.758
Encountered one or more errors while creating shader module "bin_module"
12:43:37.758
WebGPU compilation info for shader module "bin_module" (1 error(s), 0 warning(s), 0 info)
12:43:37.758

Shader validation error: Function [0] 'get_texture_linear_index' is invalid
┌─ bin_module:89:1
│
89 │ ╭ fn get_texture_linear_index(view_x: f32, view_y: f32) -> i32
90 │ │ {
91 │ │ return i32(floor(view_x) + floor(view_y) * SCREEN_WIDTH_PX);
│ │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ naga::Expression [5]
│ ╰────────────────────────────────────────────────────────────────^ naga::Function [0]
│
= Expression [5] is invalid
= Operation Multiply can't work with [3] (of type Scalar(Scalar { kind: Float, width: 4 })) and [4] (of type Scalar(Scalar { kind: Sint, width: 4 }))

12:43:37.758
Encountered one or more errors while creating shader module "fine_module"
12:43:37.758
WebGPU compilation info for shader module "fine_module" (1 error(s), 0 warning(s), 0 info)
12:43:37.758

Shader validation error: Function [0] 'get_texture_linear_index' is invalid
┌─ fine_module:89:1
│
89 │ ╭ fn get_texture_linear_index(view_x: f32, view_y: f32) -> i32
90 │ │ {
91 │ │ return i32(floor(view_x) + floor(view_y) * SCREEN_WIDTH_PX);
│ │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ naga::Expression [5]
│ ╰────────────────────────────────────────────────────────────────^ naga::Function [0]
│
= Expression [5] is invalid
= Operation Multiply can't work with [3] (of type Scalar(Scalar { kind: Float, width: 4 })) and [4] (of type Scalar(Scalar { kind: Sint, width: 4 }))

12:43:37.758
Encountered one or more errors while creating shader module "quad_fragment_module"
12:43:37.758
WebGPU compilation info for shader module "quad_fragment_module" (1 error(s), 0 warning(s), 0 info)
12:43:37.758

Shader validation error: Function [0] 'get_texture_linear_index' is invalid
┌─ quad_fragment_module:89:1
│
89 │ ╭ fn get_texture_linear_index(view_x: f32, view_y: f32) -> i32
90 │ │ {
91 │ │ return i32(floor(view_x) + floor(view_y) * SCREEN_WIDTH_PX);
│ │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ naga::Expression [5]
│ ╰────────────────────────────────────────────────────────────────^ naga::Function [0]
│
= Expression [5] is invalid
= Operation Multiply can't work with [3] (of type Scalar(Scalar { kind: Float, width: 4 })) and [4] (of type Scalar(Scalar { kind: Sint, width: 4 }))

12:43:37.758 Uncaptured WebGPU error: ShaderModule with 'rough_module' label is invalid
12:43:37.758 Uncaptured WebGPU error: ShaderModule with 'bin_module' label is invalid
12:43:37.758 Uncaptured WebGPU error: ShaderModule with 'fine_module' label is invalid
12:43:37.758 Uncaptured WebGPU error: Error matching ShaderStages(VERTEX) shader requirements against the pipeline, caused by: ShaderModule with 'quad_fragment_module' label is invalid
12:43:37.758 Uncaptured WebGPU error: ComputePipeline with '' label is invalid
12:43:37.758 Uncaptured WebGPU error: BindGroupLayout with '' label is invalid
12:43:37.758 Uncaptured WebGPU error: RenderPipeline with '' label is invalid
12:43:37.786 Uncaptured WebGPU error: In a set_pipeline command, caused by: ComputePipeline with '' label is invalid
12:43:37.786 Uncaptured WebGPU error: Command encoder is locked by a previously created render/compute pass. Before recording any new commands, the pass must be ended.
12:43:37.786 Uncaptured WebGPU error: Command encoder is invalid
12:43:37.786 Uncaptured WebGPU error: In a set_pipeline command, caused by: RenderPipeline with '' label is invalid

Comment 5

[Erich Gubler [:ErichDonGubler] (he/him)]

Latest error messages indicate a blocker on bug 1829879, which is unsurprising.

Comment 6

[Andy Leiserson [:aleiserson]]

Linking to the function database issue -- I'm currently seeing a failure on pow.

Comment 7

[Jim Blandy :jimb]

Bug 1958061 does seem to fix this.

Comment 8

[Erich Gubler [:ErichDonGubler] (he/him)]

Works now!