Open Bug 1877318 Opened 1 year ago Updated 10 months ago

New wpt failures in /css/css-writing-modes/forms/ [meter-appearance-native-vertical-rtl.optional.html, meter-appearance-native-vertical.optional.html, progress-appearance-native-vertical-rtl.optional.html, and 3 others]

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
ASSIGNED

People

(Reporter: wpt-sync, Assigned: dholbert)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [wpt])

Syncing wpt PR 44241 found new untriaged test failures in CI

Tests Affected

Firefox-only failures

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1876863 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

These tests seem to be testing the spec-change in https://github.com/whatwg/html/pull/10096 which is changing vertical-writing-mode meter/progress/input[type=range] to now start caring about the direction property (where previously the spec required them to ignore it).

This seems like a reasonable change, but it's a spec change which is why we fail the tests.

RE this being a Firefox-only failure:

  • Chrome actually gives the same results as us when I test this feature locally, so maybe they've only just shipped a fix for this, or it's behind a pref that's not on for users yet?
  • Safari 17.3 seems to disregard writing-mode entirely on these form controls (they just render them horizontally); and so they sort of spuriously pass these WPTs, by virtue of honoring direction on forced-to-be-horizontal form-controls. (Maybe they've got it implemented more robustly on trunk though? not sure.)

Side note, these tests have a handful of redundant checks baked in. Both of these tests have a mismatch condition saying that they expect to mismatch the other one:

meter-appearance-native-vertical.optional.html
meter-appearance-native-vertical-rtl.optional.html

And we run each test separately, and for each test we compare it to the other, and then judge the whole test as a failure because we failed to mismatch (because we're ignoring direction due to not yet implementing https://github.com/whatwg/html/pull/10096 ).

This pattern of two files using the other as a reference case (or mismatch case) seems maybe like something we might want to discourage, perhaps, to avoid redundant CI-work and to avoid multiple failures for what really is a single unexpected comparison.

Severity: -- → S3

This is pretty straightforward to fix, so I figured I'd just fix it as long as I'm looking at the relevant code.

Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Blocks: 1877867
Depends on: 1877872

(In reply to Daniel Holbert [:dholbert] from comment #3)

This is pretty straightforward to fix, so I figured I'd just fix it as long as I'm looking at the relevant code.

(actually, I posted some minor concerns in https://github.com/whatwg/html/issues/8413 ; I'll wait to see what the outcome of that is before proceeding here.)

You need to log in before you can comment on or make changes to this bug.