1877419 - Strip nested URIs of tracking query parameters with Clean Copy

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement)

Comment 1

[Abhishek Madan[:abhishekmadan]]

Attachment: Bug 1877419 - Part 1: Added nested stripping of urls to copy without site tracking. r=pbz!

Comment 2

[Abhishek Madan[:abhishekmadan]]

Attachment: Bug 1877419 - Part 2: Added tests for nested stripping for Strip on Share. r=pbz

Depends on D202943

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2ca2f596c09
Part 1: Added nested stripping of urls to copy without site tracking. r=pbz,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/32c74a4cd05b
Part 2: Added tests for nested stripping for Strip on Share. r=pbz

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out 3 changesets (Bug 1884941, Bug 1877419) for causing bustage in URLQueryStringStripper.cpp CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=32c74a4cd05b13504875d6c230bf57107181ce5f

Log: https://treeherder.mozilla.org/logviewer?job_id=452213246&repo=autoland&lineNumber=129210

Backout: https://hg.mozilla.org/integration/autoland/rev/77c934059cc9dd5ba0dac1d3af3a02ecc7df9ed5

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7fab4b145f7
Part 1: Added nested stripping of urls to copy without site tracking. r=pbz,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/53db0be27620
Part 2: Added tests for nested stripping for Strip on Share. r=pbz

Comment 6

[Iulian Moraru]

Backed out for causing non unified build bustages on URLQueryStringStripper.cpp.

• Push with failures

• Failure log

• Backout link

[task 2024-03-26T17:28:38.446Z] 17:28:38     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/components/antitracking'
[task 2024-03-26T17:28:38.449Z] 17:28:38     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot-x86_64-linux-gnu -o URLQueryStringStripper.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/toolkit/components/antitracking -I/builds/worker/workspace/obj-build/toolkit/components/antitracking -I/builds/worker/checkouts/gecko/netwerk/base -I/builds/worker/checkouts/gecko/netwerk/protocol/http -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -gdwarf-4 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Werror -Wall -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wenum-compare-conditional -Wenum-float-conversion -Wno-error=deprecated -Wno-error=deprecated-anon-enum-enum-conversion -Wno-error=deprecated-enum-enum-conversion -Wno-error=deprecated-pragma -Wno-error=deprecated-this-capture -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wformat -Wformat-security -Wno-psabi -Wthread-safety -Wno-error=builtin-macro-redefined -Wno-unknown-warning-option -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/URLQueryStringStripper.o.pp   /builds/worker/checkouts/gecko/toolkit/components/antitracking/URLQueryStringStripper.cpp
[task 2024-03-26T17:28:38.449Z] 17:28:38    ERROR -  /builds/worker/checkouts/gecko/toolkit/components/antitracking/URLQueryStringStripper.cpp:445:11: error: use of undeclared identifier 'LOG'
[task 2024-03-26T17:28:38.450Z] 17:28:38     INFO -    445 |           LOG(("Unable to obtain ioService"));
[task 2024-03-26T17:28:38.450Z] 17:28:38     INFO -        |           ^
[task 2024-03-26T17:28:38.450Z] 17:28:38     INFO -  1 error generated.
[task 2024-03-26T17:28:38.450Z] 17:28:38    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:688: URLQueryStringStripper.o] Error 1
[task 2024-03-26T17:28:38.450Z] 17:28:38     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/components/antitracking'

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1e9b8e21d42
Part 1: Added nested stripping of urls to copy without site tracking. r=pbz,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/aadd2e3e6f9e
Part 2: Added tests for nested stripping for Strip on Share. r=pbz

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f1e9b8e21d42
https://hg.mozilla.org/mozilla-central/rev/aadd2e3e6f9e